Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: generate OpenAPI JSON from APIB #602

Merged
merged 1 commit into from
Sep 29, 2024
Merged

Conversation

SMillerDev
Copy link
Owner

No description provided.

@SMillerDev SMillerDev force-pushed the feat/out/generate_openapi branch 3 times, most recently from e58355c to 25969b4 Compare September 29, 2024 09:52
Copy link

codecov bot commented Sep 29, 2024

Codecov Report

Attention: Patch coverage is 37.87234% with 146 lines in your changes missing coverage. Please review.

Project coverage is 71.37%. Comparing base (71bb7ec) to head (f571f28).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/PHPDraft/Out/OpenAPI/OpenApiRenderer.php 49.31% 74 Missing ⚠️
...PHPDraft/Out/OpenAPI/Tests/OpenApiRendererTest.php 0.00% 62 Missing ⚠️
src/PHPDraft/Out/BaseTemplateRenderer.php 66.66% 5 Missing ⚠️
src/PHPDraft/Out/TwigFactory.php 0.00% 3 Missing ⚠️
src/PHPDraft/Parse/Drafter.php 50.00% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main     #602      +/-   ##
============================================
- Coverage     79.67%   71.37%   -8.31%     
- Complexity      324      381      +57     
============================================
  Files            23       26       +3     
  Lines           797     1013     +216     
============================================
+ Hits            635      723      +88     
- Misses          162      290     +128     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@SMillerDev SMillerDev marked this pull request as ready for review September 29, 2024 12:18
@SMillerDev SMillerDev force-pushed the feat/out/generate_openapi branch 11 times, most recently from afeb781 to 6aa8cbe Compare September 29, 2024 14:16
Copy link

sonarcloud bot commented Sep 29, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
54.4% Coverage on New Code (required ≥ 80%)

See analysis details on SonarCloud

@SMillerDev SMillerDev merged commit d7a10a0 into main Sep 29, 2024
4 of 9 checks passed
@SMillerDev SMillerDev deleted the feat/out/generate_openapi branch September 29, 2024 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant