Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix PHPUnit 10 compat #489

Merged
merged 1 commit into from
Jul 17, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .gitignore
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
/.idea/
/.phpintel/
/tests/.phpunit.cache/**
/tests/.phpunit.result.cache

# IntelliJ
Expand Down
9 changes: 5 additions & 4 deletions composer.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@ public function testSuccessfulParse(string $object, ArrayStructureElement $expec
*
* @return array
*/
public function parseObjectProvider(): array
public static function parseObjectProvider(): array
{
$return = [];
$base1 = new ArrayStructureElement();
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,7 @@ public function testStringValue(mixed $value, mixed $string_value): void
*
* @return array
*/
public function stringValueProvider(): array
public static function stringValueProvider(): array
{
$return = [];

Expand Down Expand Up @@ -134,7 +134,7 @@ public function testParseCommon($value, BasicStructureElement $expected_value):
$this->assertEquals([], $dep);
}

public function parseValueProvider(): array
public static function parseValueProvider(): array
{
$return = [];

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -141,7 +141,7 @@ public function testSuccessfulParse(string $object, EnumStructureElement $expect
*
* @return array
*/
public function parseObjectProvider(): array
public static function parseObjectProvider(): array
{
$value1 = new ElementStructureElement();
$value1->value = 'item';
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@ public function testNewInstance(): void
*
* @covers \PHPDraft\Model\Elements\ObjectStructureElement::parse
*/
public function testSuccesfulParse(string $object, ObjectStructureElement $expected): void
public function testSuccessfulParse(string $object, ObjectStructureElement $expected): void
{
$dep = [];
$res = $this->class->parse(json_decode($object), $dep);
Expand All @@ -73,7 +73,7 @@ public function testSuccesfulParse(string $object, ObjectStructureElement $expec
*
* @return array
*/
public function parseObjectProvider(): array
public static function parseObjectProvider(): array
{
$return = [];
$base1 = new ObjectStructureElement();
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -135,7 +135,7 @@ public function testSuccessfulParse(string $object, ObjectStructureElement $expe
*
* @return array
*/
public function parseObjectProvider(): array
public static function parseObjectProvider(): array
{
$return = [];
$base1 = new RequestBodyElement();
Expand Down
19 changes: 18 additions & 1 deletion src/PHPDraft/Model/Tests/CategoryTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@
* Class CategoryTest
* @covers \PHPDraft\Model\Category
*/
class CategoryTest extends HierarchyElementChildTest
class CategoryTest extends HierarchyElementChildTestBase
{
/**
* Set up
Expand All @@ -38,6 +38,23 @@ public function tearDown(): void
unset($this->reflection);
}

/**
* Test if the value the class is initialized with is correct
* @covers \PHPDraft\Model\HierarchyElement
*/
public function testChildrenSetup(): void
{
$this->assertSame([], $this->class->children);
}

/**
* Test if the value the class is initialized with is correct
*/
public function testSetupCorrectly(): void
{
$this->assertPropertySame('parent', null);
}

/**
* Test if the value the class is initialized with is correct
*/
Expand Down
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
<?php

/**
* This file contains the HierarchyElementChildTest.php
* This file contains the HierarchyElementChildTestBase.php
*
* @package PHPDraft\Model
* @author Sean Molenaar<[email protected]>
Expand All @@ -17,7 +17,7 @@
* Class HierarchyElementChildTest
* @package PHPDraft\Model\Tests
*/
class HierarchyElementChildTest extends LunrBaseTest
abstract class HierarchyElementChildTestBase extends LunrBaseTest
{
/**
* Mock of the parent class
Expand All @@ -31,22 +31,4 @@ public function setUp(): void
$this->parent = $this->getMockBuilder('\PHPDraft\Model\HierarchyElement')
->getMock();
}

/**
* Test if the value the class is initialized with is correct
*/
public function testChildrenSetup(): void
{
$this->assertSame([], $this->class->children);
}

/**
* Test if the value the class is initialized with is correct
*/
public function testSetupCorrectly(): void
{
$property = $this->reflection->getProperty('parent');
$property->setAccessible(true);
$this->assertNull($property->getValue($this->class));
}
}
23 changes: 22 additions & 1 deletion src/PHPDraft/Model/Tests/ObjectElementTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -16,36 +16,57 @@
*/
class ObjectElementTest extends LunrBaseTest
{
/**
* @covers \PHPDraft\Model\Elements\ObjectStructureElement
*/
public function testKeySetup(): void
{
$this->assertSame(null, $this->class->key);
}

/**
* @covers \PHPDraft\Model\Elements\ObjectStructureElement
*/
public function testTypeSetup(): void
{
$this->assertSame(null, $this->class->type);
}

/**
* @covers \PHPDraft\Model\Elements\ObjectStructureElement
*/
public function testDescriptionSetup(): void
{
$this->assertSame(null, $this->class->description);
}

/**
* @covers \PHPDraft\Model\Elements\ObjectStructureElement
*/
public function testElementSetup(): void
{
$this->assertSame(null, $this->class->element);
}

/**
* @covers \PHPDraft\Model\Elements\ObjectStructureElement
*/
public function testValueSetup(): void
{
$this->assertSame(null, $this->class->value);
}

/**
* @covers \PHPDraft\Model\Elements\ObjectStructureElement
*/
public function testStatusSetup(): void
{
$this->assertSame('', $this->class->status);
$this->assertSame(null, $this->class->status);
}

/**
* @covers \PHPDraft\Model\Elements\ObjectStructureElement
*/
public function testDepsSetup(): void
{
$this->assertSame(null, $this->class->deps);
Expand Down
12 changes: 11 additions & 1 deletion src/PHPDraft/Model/Tests/TransitionTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@
* Class TransitionTest
* @covers \PHPDraft\Model\Transition
*/
class TransitionTest extends HierarchyElementChildTest
class TransitionTest extends HierarchyElementChildTestBase
{
/**
* Set up
Expand All @@ -40,6 +40,16 @@ public function tearDown(): void
unset($this->parent);
}


/**
* Test if the value the class is initialized with is correct
* @covers \PHPDraft\Model\HierarchyElement
*/
public function testChildrenSetup(): void
{
$this->assertSame([], $this->class->children);
}

/**
* Test if the value the class is initialized with is correct
*/
Expand Down
4 changes: 2 additions & 2 deletions src/PHPDraft/Out/Tests/TemplateRendererTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@ public function testStripSpaces(): void
* Provide HTTP status codes
* @return array<int, array<int, int|string>>
*/
public function responseStatusProvider(): array
public static function responseStatusProvider(): array
{
$return = [];

Expand Down Expand Up @@ -93,7 +93,7 @@ public function testResponseStatus(int $code, string $text): void
* Provide HTTP methods
* @return array<int, array<int, string>>
*/
public function requestMethodProvider(): array
public static function requestMethodProvider(): array
{
$return = [];

Expand Down
117 changes: 47 additions & 70 deletions tests/phpunit.xml
Original file line number Diff line number Diff line change
@@ -1,72 +1,49 @@
<?xml version="1.0" encoding="UTF-8"?>
<phpunit xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
xsi:noNamespaceSchemaLocation="https://schema.phpunit.de/9.3/phpunit.xsd"
bootstrap="test.bootstrap.inc.php"
backupGlobals="false"
backupStaticAttributes="false"
forceCoversAnnotation="true"
colors="true"
verbose="true">
<php>
<ini name="zend.enable_gc" value="1" />
</php>
<testsuites>
<testsuite name="Parse">
<file>../src/PHPDraft/Parse/Tests/BaseParserTest.php</file>
<file>../src/PHPDraft/Parse/Tests/DrafterTest.php</file>
<file>../src/PHPDraft/Parse/Tests/DrafterAPITest.php</file>
<file>../src/PHPDraft/Parse/Tests/HtmlGeneratorTest.php</file>
<file>../src/PHPDraft/Parse/Tests/BaseHtmlGeneratorTest.php</file>
<file>../src/PHPDraft/Parse/Tests/ParserFactoryTest.php</file>
</testsuite>
<testsuite name="Model">
<file>../src/PHPDraft/Model/Tests/CategoryTest.php</file>
<file>../src/PHPDraft/Model/Tests/HierarchyElementTest.php</file>
<file>../src/PHPDraft/Model/Tests/HTTPRequestTest.php</file>
<file>../src/PHPDraft/Model/Tests/HTTPResponseTest.php</file>
<file>../src/PHPDraft/Model/Tests/ResourceTest.php</file>
<file>../src/PHPDraft/Model/Tests/TransitionTest.php</file>
<file>../src/PHPDraft/Model/Elements/Tests/BasicStructureElementTest.php</file>
<file>../src/PHPDraft/Model/Elements/Tests/EnumStructureElementTest.php</file>
<file>../src/PHPDraft/Model/Elements/Tests/ObjectStructureElementTest.php</file>
<file>../src/PHPDraft/Model/Elements/Tests/ArrayStructureElementTest.php</file>
<file>../src/PHPDraft/Model/Elements/Tests/RequestBodyElementTest.php</file>
<file>../src/PHPDraft/Model/Elements/Tests/ElementStructureElementTest.php</file>
</testsuite>
<testsuite name="In">
<file>../src/PHPDraft/In/Tests/ApibFileParserTest.php</file>
</testsuite>
<testsuite name="Out">
<file>../src/PHPDraft/Out/Tests/VersionTest.php</file>
<file>../src/PHPDraft/Out/Tests/SortingTest.php</file>
<file>../src/PHPDraft/Out/Tests/TemplateRendererTest.php</file>
<file>../src/PHPDraft/Out/Tests/TwigFactoryTest.php</file>
</testsuite>
</testsuites>
<coverage>
<include>
<directory>../src/PHPDraft/</directory>
</include>
<exclude>
<directory>../src/PHPDraft/Core/</directory>
<directory>../src/PHPDraft/In/Tests/</directory>
<directory>../src/PHPDraft/Model/Tests/</directory>
<directory>../src/PHPDraft/Model/Elements/Tests/</directory>
<directory>../src/PHPDraft/Out/Tests/</directory>
<directory>../src/PHPDraft/Out/HTML/</directory>
<directory>../src/PHPDraft/Parse/Tests/</directory>
<file>../src/PHPDraft/Model/Comparable.php</file>
<file>../src/PHPDraft/Model/Elements/StructureElement.php</file>
<file>../src/PHPDraft/Out/Minifier.php</file>
<file>../src/PHPDraft/Parse/ResourceException.php</file>
<file>../src/PHPDraft/**Exception.php</file>
</exclude>
<report>
<clover outputFile="../build/logs/clover.xml"/>
<html outputDirectory="../build/coverage" lowUpperBound="35" highLowerBound="70"/>
</report>
</coverage>
<logging>
<junit outputFile="../build/logs/junit.xml"/>
</logging>
<phpunit xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:noNamespaceSchemaLocation="https://schema.phpunit.de/10.2/phpunit.xsd" bootstrap="test.bootstrap.inc.php" backupGlobals="false" colors="true" cacheDirectory=".phpunit.cache" backupStaticProperties="false" requireCoverageMetadata="true">
<php>
<ini name="zend.enable_gc" value="1"/>
</php>
<testsuites>
<testsuite name="In">
<directory>../src/PHPDraft/In/Tests/</directory>
</testsuite>
<testsuite name="Model">
<directory>../src/PHPDraft/Model/Tests/</directory>
<directory>../src/PHPDraft/Model/Elements/Tests/</directory>
</testsuite>
<testsuite name="Out">
<directory>../src/PHPDraft/Out/Tests/</directory>
</testsuite>
<testsuite name="Parse">
<directory>../src/PHPDraft/Parse/Tests/</directory>
</testsuite>
</testsuites>
<coverage>
<report>
<clover outputFile="../build/logs/clover.xml"/>
<html outputDirectory="../build/coverage" lowUpperBound="35" highLowerBound="70"/>
</report>
</coverage>
<logging>
<junit outputFile="../build/logs/junit.xml"/>
</logging>
<source>
<include>
<directory>../src/PHPDraft/</directory>
</include>
<exclude>
<directory>../src/PHPDraft/Core/</directory>
<directory>../src/PHPDraft/In/Tests/</directory>
<directory>../src/PHPDraft/Model/Tests/</directory>
<directory>../src/PHPDraft/Model/Elements/Tests/</directory>
<directory>../src/PHPDraft/Out/Tests/</directory>
<directory>../src/PHPDraft/Out/HTML/</directory>
<directory>../src/PHPDraft/Parse/Tests/</directory>
<file>../src/PHPDraft/Model/Comparable.php</file>
<file>../src/PHPDraft/Model/Elements/StructureElement.php</file>
<file>../src/PHPDraft/Out/Minifier.php</file>
<file>../src/PHPDraft/Parse/ResourceException.php</file>
<file>../src/PHPDraft/**Exception.php</file>
</exclude>
</source>
</phpunit>
Empty file removed tests/statics/drafter/index.apib
Empty file.
Loading