Draft
Conversation
This reverts commit 6d12e4d.
This change allows us to catch all exceptions and choose cases we want to pass downstream, crashing on all others. This fixes an issue where IsIdentifiable should have crashed when encountering a corrupt file instead of sending an ErrorWontRetry message downstream.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1806 +/- ##
==========================================
+ Coverage 59.79% 59.80% +0.01%
==========================================
Files 177 177
Lines 6332 6334 +2
Branches 870 871 +1
==========================================
+ Hits 3786 3788 +2
Misses 2305 2305
Partials 241 241 ☔ View full report in Codecov by Sentry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Summarise your proposed changes here, including any notes for reviewers.
Types of changes
What types of changes does your code introduce? Tick all that apply.
[skip ci]Checklist
By opening this PR, I confirm that I have:
Issues
If relevant, tag any issues that are expected to be resolved with this PR. E.g.: