Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Equ more cleanly #617

Merged
merged 2 commits into from
Jan 13, 2025
Merged

Remove Equ more cleanly #617

merged 2 commits into from
Jan 13, 2025

Conversation

jas88
Copy link
Member

@jas88 jas88 commented Jan 13, 2025

Replacement for PR #552

@jas88 jas88 requested a review from rkm January 13, 2025 20:24
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 41.66667% with 7 lines in your changes missing coverage. Please review.

Project coverage is 39.49%. Comparing base (8e29f0d) to head (ad07799).

Files with missing lines Patch % Lines
IsIdentifiable/Rules/AllowListRule.cs 0.00% 6 Missing ⚠️
IsIdentifiable/Rules/RegexRule.cs 83.33% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #617   +/-   ##
=======================================
  Coverage   39.48%   39.49%           
=======================================
  Files          68       68           
  Lines        3839     3851   +12     
  Branches      521      527    +6     
=======================================
+ Hits         1516     1521    +5     
- Misses       2224     2230    +6     
- Partials       99      100    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jas88 jas88 mentioned this pull request Jan 13, 2025
@jas88 jas88 merged commit 0479e1a into main Jan 13, 2025
5 checks passed
@jas88 jas88 deleted the feature/nequredo branch January 13, 2025 21:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants