[WIP] Fix 4282 file dir conflict stacktrace #4284
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… format string. Created FileWhereDirectoryExpectedError and DirWhereFileExpectedError exceptions which are children of TypeError (The previous exception raised when there was a mismatch.
…d of previously stderr
mwichmann
reviewed
Dec 21, 2022
| return fmt % self.node_path | ||
|
|
||
|
|
||
| class DirWhereFileExpectedError(SCons.Errors.BuildError): |
There was a problem hiding this comment.
feels like a bit of overkill to define individual exceptions for this, but that's not a big deal.
There was a problem hiding this comment.
DirWhereFile and FileWhereDir result in different fixes/issues.. removing a file to put a dir is easy, but not vice versa.
Or at least that was the thought.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Handle dir or file where file or dir expected better than just a long stack trace.
Contributor Checklist:
CHANGES.txt(and read theREADME.rst)