Skip to content

feat(ui5-search-item): byline item support #11503

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

feat(ui5-search-item): byline item support #11503

wants to merge 2 commits into from

Conversation

MapTo0
Copy link
Member

@MapTo0 MapTo0 commented May 12, 2025

  • property: description to display byline text
  • slot: image to display avatar in the item
<ui5-search-item text="List Item" description="Byline"></ui5-search-item>

<ui5-search-item text="List item" description="Byline">
  <ui5-avatar slot="image" size="XS">
    <img src="./img/John_Miller.png" alt="John Miller">
  </ui5-avatar>
</ui5-search-item>

<ui5-search-item text="List item" description="Byline" icon="globe"></ui5-search-item>
image

- new property: description to display byline text
- new slot: image to display avatar in the item
@MapTo0 MapTo0 requested a review from elenastoyanovaa May 12, 2025 14:07
Copy link
Contributor

@elenastoyanovaa elenastoyanovaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add a sample in the playground

*
* @public
*/
@slot()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add docu that if an icon is set, the image will not be rendered

display: inline-block;
}

.ui5-search-item-subheading {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why not description? isn't it confusing to have a text property and render it as a .ui5-search-item-heading and a description and name it .ui5-search-item-subheading. Both of them are not heading semantically, why naming them like that.

@@ -18,8 +18,16 @@

<ui5-search>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps add a separate test sample pointing that it shows byline items, instead of polluting the old one's, it will be easier for testing and testers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants