-
Notifications
You must be signed in to change notification settings - Fork 275
feat(ui5-search-item): byline item support #11503
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
- new property: description to display byline text - new slot: image to display avatar in the item
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add a sample in the playground
* | ||
* @public | ||
*/ | ||
@slot() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
add docu that if an icon is set, the image will not be rendered
display: inline-block; | ||
} | ||
|
||
.ui5-search-item-subheading { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why not description? isn't it confusing to have a text property and render it as a .ui5-search-item-heading and a description and name it .ui5-search-item-subheading. Both of them are not heading semantically, why naming them like that.
@@ -18,8 +18,16 @@ | |||
|
|||
<ui5-search> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perhaps add a separate test sample pointing that it shows byline items, instead of polluting the old one's, it will be easier for testing and testers.
description
to display byline textimage
to display avatar in the item