docs(ui5-side-navigation): await upgrade of groups in samples by changing the import order #11203
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
…ing the import order
dimovpetar
force-pushed
the
sn_samples_import_order
branch
from
93d1a11 to
020fea8
Compare
There was a problem hiding this comment.
Pull Request Overview
This PR fixes the import order for the UI5 SideNavigation component in various Fiori sample applications to support the upcoming upgrade of groups.
- Reorders the import of "@ui5/webcomponents-fiori/dist/SideNavigation.js" in multiple sample files.
- Ensures consistency across sample apps and the bundle in "packages/fiori/src/bundle.esm.ts".
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| packages/website/docs/_samples/fiori/SideNavigation/UnselectableParentItems/main.js | Moves the SideNavigation import to a new position after item imports. |
| packages/website/docs/_samples/fiori/SideNavigation/QuickAction/main.js | Adjusts SideNavigation import order to follow group-specific imports. |
| packages/website/docs/_samples/fiori/SideNavigation/OverlayMode/main.js | Reorders SideNavigation import and removes a duplicate import of SideNavigationGroup. |
| packages/website/docs/_samples/fiori/SideNavigation/Basic/main.js | Reorders SideNavigation import to match the new convention. |
| packages/fiori/src/bundle.esm.ts | Updates the import order for SideNavigation to align with the change across samples. |
1 task
dimovpetar
changed the title
TeodorTaushanov
approved these changes
Apr 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #11172