-
Notifications
You must be signed in to change notification settings - Fork 275
feat(ui5-dynamic-date-range): work in progress #10895
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
tsanislavgatev
wants to merge
17
commits into
main
Choose a base branch
from
ddr-structure
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
High-level notes:
|
|
vladitasev
reviewed
May 16, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good
unazko
reviewed
May 22, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Lacking "Has Details" announcement for the list items
- Lacking tooltip for the navigation icon (should not be decorative)
- Lacking hover effects over the value help icon
- Value help icon should be pressed twice to open the popover
- Press out of the popover doesn't close the popover
- Initial focus should be over the selected option if such is present
- F4, Option + Arrow Up/Down doesn't toggle the value help
- The text element showcasing the selected date in the SingleDate option details doesn't get cleared after the text is erased from the input (On next open we have the previous value)
- If we navigate to the SingleDate option detail page and close the value help then on next value help open we'll be directly navigated to the SingleDate option page again.
- After navigation the focus is not getting visualised (back and in details pages)
- If we select a Date from the SingleDate page and then navigate to the DateRange page we'll already have a selected start date in the range, which appears unexpected. We do have similar mixing with the other options as well. For example if we select Yesterday and then open the SingleDate option we'll already have a selected date.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do not review, presentational purposes only.