chore(TableRowActionBase): the actions slot is set automatically #10766
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @vladitasev as mentioned this works for the test page but not when we remove the slot="actions" in the test file TableRowActions.cy.tsx |
|
is this going to be merged? we are looking forward to remove unnecessary slot attributes from the table dedicated components |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
autoSlotadded, allowing a component to be automatically assigned to a certain slot based on its class (in this exampleui5-table-row-actionautomatically getsslot="actions"without the user having to type it explicitlyUI5Element.ts- when children are processed slot information is gathered before children are upgraded, making them always go to the default slot