fix: (CXSPA-9010) Previous field error message read. #20071
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
StanislavSukhanov
commented
Mar 12, 2025
StanislavSukhanov
commented
- closes: https://jira.tools.sap/browse/CXSPA-9010
spartacus
|
||||||||||||||||||||||||||||
| Project |
spartacus
|
| Branch Review |
feature/CXSPA-9010-previous-error-message-is-read-to-user
|
| Run status |
|
| Run duration | 04m 38s |
| Commit |
|
| Committer | Stanislav Sukhanov |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
4
|
Pending
|
0
|
Skipped
|
0
|
Passing
|
118
|
| View all changes introduced in this branch ↗︎ | |
Pio-Bar
previously approved these changes
Mar 12, 2025
Zeyber
requested changes
Mar 24, 2025
| @@ -1074,6 +1080,7 @@ export const defaultFeatureToggles: Required<FeatureTogglesInterface> = { | |||
| a11yStoreFinderAlerts: true, | |||
| a11yStoreFinderLabel: false, | |||
| a11yFormErrorMuteIcon: true, | |||
| a11yImprovedErrorMessage: true, | |||
There was a problem hiding this comment.
I think we should introduce this as false by default.
There was a problem hiding this comment.
Yes, you are right! Thanks a lot for noticing.
| @@ -40,8 +42,22 @@ import { map, startWith } from 'rxjs/operators'; | |||
| export class FormErrorsComponent implements DoCheck { | |||
| private featureConfigService = inject(FeatureConfigService); | |||
|
|
|||
| private elementRef = inject(ElementRef); | |||
| constructor(protected ChangeDetectionRef: ChangeDetectorRef) { | ||
| useFeatureStyles('a11yFormErrorMuteIcon'); | ||
| if (this.featureConfigService.isEnabled('a11yImprovedErrorMessage')) { |
There was a problem hiding this comment.
We could move this logic into its own method just to be a little tidier.
| if (!ariaLive) { | ||
| // If no aria-live value is set add 'polite' as a default. This is preferred over setting | ||
| // role='alert' so that screen readers do not interrupt the current task to read this aloud. | ||
| this.elementRef.nativeElement.setAttribute('aria-live', 'polite'); |
There was a problem hiding this comment.
We should be careful with DOM manipulation on page instantiation because it can cause issues with SSR and hydration. Is it possible to set the attribute using an Angular-friendly method (eg. template, input value)?
https://angular.dev/guide/hydration#direct-dom-manipulation
StanislavSukhanov
force-pushed
the
feature/CXSPA-9010-previous-error-message-is-read-to-user
branch
from
e65e7fe to
9aa51c5
Compare
Zeyber
requested changes
Mar 25, 2025
| @@ -35,13 +38,24 @@ import { map, startWith } from 'rxjs/operators'; | |||
| selector: 'cx-form-errors', | |||
| templateUrl: './form-errors.component.html', | |||
| changeDetection: ChangeDetectionStrategy.OnPush, | |||
| host: { | |||
There was a problem hiding this comment.
Do you think we could use @HostBindings for these attributes like you did for attr.role? I think it could be easier to understand and modify.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.