fix: (CXSPA-9018) - Fix extra reading issue when tab-panel is focused in 'Delivery method' #19920
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spartacus
|
||||||||||||||||||||||||||||||
| Project |
spartacus
|
| Branch Review |
feature/CXSPA-9018
|
| Run status |
|
| Run duration | 13m 58s |
| Commit |
|
| Committer | petarmarkov9449 |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
3
|
Pending
|
2
|
Skipped
|
0
|
Passing
|
125
|
Upgrade your plan to view test results. | |
| View all changes introduced in this branch ↗︎ | |
sdrozdsap
previously approved these changes
Jan 31, 2025
Zeyber
requested changes
Feb 3, 2025
| [tabs]="tabs" | ||
| [config]="tabConfig" | ||
| ></cx-tab> | ||
| <div> |
There was a problem hiding this comment.
Do we need to add div to the DOM? Its a breaking change if we need to.
There was a problem hiding this comment.
I've just removed it.
I think it was added by a mistake.
Zeyber
approved these changes
Feb 3, 2025
StanislavSukhanov
requested changes
Feb 21, 2025
| @@ -1,7 +1,6 @@ | |||
| <div | |||
| [attr.role]="mode === TAB_MODE.ACCORDIAN ? 'region' : 'tabpanel'" | |||
| [tabindex]="tab.disableBorderFocus ? -1 : 0" | |||
| [attr.aria-labelledby]="tab.id ?? null" | |||
There was a problem hiding this comment.
let's roll back this line
| @@ -46,7 +46,6 @@ describe('TabPanelComponent', () => { | |||
| expect(tabPanel?.getAttribute('tabindex')).toEqual('0'); | |||
| expect(tabPanel?.getAttribute('role')).toEqual('tabpanel'); | |||
| expect(tabPanel?.getAttribute('class')).toEqual('active'); | |||
| expect(tabPanel?.getAttribute('aria-labelledby')).toEqual('1'); | |||
There was a problem hiding this comment.
lets roll back this :)
| @@ -58,7 +57,6 @@ describe('TabPanelComponent', () => { | |||
| expect(tabPanel?.getAttribute('tabindex')).toEqual('0'); | |||
| expect(tabPanel?.getAttribute('role')).toEqual('region'); | |||
| expect(tabPanel?.getAttribute('class')).toEqual('active'); | |||
| expect(tabPanel?.getAttribute('aria-labelledby')).toEqual('1'); | |||
|
Closing as the changes have already been merged in #19956 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket: CXSPA-9018
Fix extra reading issue when tab-panel is focused in 'Delivery method'.
Affects: TabPanelComponent