Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: focus indicator overlapping with other elements #19268

Merged
merged 2 commits into from
Sep 20, 2024
Merged

fix: focus indicator overlapping with other elements #19268

merged 2 commits into from
Sep 20, 2024

Conversation

steinsebastian
Copy link
Contributor

CXSPA-7951

@steinsebastian steinsebastian requested review from a team as code owners September 19, 2024 14:24
@github-actions github-actions bot marked this pull request as draft September 19, 2024 14:24
@steinsebastian steinsebastian marked this pull request as ready for review September 19, 2024 14:26
@cypress Cypress
Copy link

cypress bot commented Sep 19, 2024 •
edited
Loading

spartacus    Run #44948

Run Properties:  status check passed Passed #44948  •  git commit f1d8ee7ad5 ℹ️: Merge 6ab75a2543bed06e1abec47194cfdc2ab19e22f4 into ab4482fed50e52f0f8c8e552722b...
Project spartacus
Branch Review feature/CXSPA-7951
Run status status check passed Passed #44948
Run duration 05m 31s
Commit git commit f1d8ee7ad5 ℹ️: Merge 6ab75a2543bed06e1abec47194cfdc2ab19e22f4 into ab4482fed50e52f0f8c8e552722b...
Committer steinsebastian
View all properties for this run ↗︎
Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 5
Tests that did not run due to a developer annotating a test with .skip  Pending 2
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 121
View all changes introduced in this branch ↗︎

@github-actions github-actions bot marked this pull request as draft September 20, 2024 07:11
@Uli-Tiger Uli-Tiger marked this pull request as ready for review September 20, 2024 08:27
Uli-Tiger
Uli-Tiger approved these changes Sep 20, 2024
View reviewed changes
Copy link
Contributor

@Uli-Tiger Uli-Tiger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Uli-Tiger Uli-Tiger merged commit 06f08ae into develop Sep 20, 2024
28 checks passed
@Uli-Tiger Uli-Tiger deleted the feature/CXSPA-7951 branch September 20, 2024 09:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Uli-Tiger Uli-Tiger Uli-Tiger approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@steinsebastian @Uli-Tiger