Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: in dev mode pretty-print multi-line strings in logs #19266

Merged
merged 19 commits into from
Sep 20, 2024
Merged

fix: in dev mode pretty-print multi-line strings in logs #19266

merged 19 commits into from
Sep 20, 2024

Commits on Sep 18, 2024

  1. fix: context.error was not printed because JSON.stringify(Error) does… 

    …n't work by default in JS
    @Platonn
    Platonn committed Sep 18, 2024
    Configuration menu
    Copy the full SHA
    8ad3f4d View commit details
    Browse the repository at this point in the history

  2. revert testing code comitted accidentally in storefront.component

    @Platonn
    Platonn committed Sep 18, 2024
    Configuration menu
    Copy the full SHA
    d534d3b View commit details
    Browse the repository at this point in the history

  3. refactor: instead of focusing on context.error property, let's repl… 

    …ace ANY `instance of Error` property (e.g. it could be the "message" property as well or potentially other context property)
    @Platonn
    Platonn committed Sep 18, 2024
    Configuration menu
    Copy the full SHA
    9d622d7 View commit details
    Browse the repository at this point in the history

  4. fix: print multi-line strings as new lines instead of \\n

    @Platonn
    Platonn committed Sep 18, 2024
    Configuration menu
    Copy the full SHA
    5c8c13e View commit details
    Browse the repository at this point in the history

  5. revert: don't add 2 extra spaces at the beginning of each new line - … 

    …as in some cases it might be more confusing than helpful
    @Platonn
    Platonn committed Sep 18, 2024
    Configuration menu
    Copy the full SHA
    a6834c8 View commit details
    Browse the repository at this point in the history

  6. revert: don't convert multi-line strings to real newlines. It's plann… 

    …ed in a different PR
    @Platonn
    Platonn committed Sep 18, 2024
    Configuration menu
    Copy the full SHA
    51d5277 View commit details
    Browse the repository at this point in the history

  7. test: add unit tests

    @Platonn
    Platonn committed Sep 18, 2024
    Configuration menu
    Copy the full SHA
    3b12cf7 View commit details
    Browse the repository at this point in the history

  8. revert: changes in server.ts

    @Platonn
    Platonn committed Sep 18, 2024
    Configuration menu
    Copy the full SHA
    e664922 View commit details
    Browse the repository at this point in the history

Commits on Sep 19, 2024

  1. fix(express-logger.service): don't use breakLine: Infinity in dev mode

    @Platonn
    Platonn committed Sep 19, 2024
    Configuration menu
    Copy the full SHA
    86b894f View commit details
    Browse the repository at this point in the history

  2. fix JSDOcs

    @Platonn
    Platonn committed Sep 19, 2024
    Configuration menu
    Copy the full SHA
    0d04c77 View commit details
    Browse the repository at this point in the history

  3. test: fix unit tests

    @Platonn
    Platonn committed Sep 19, 2024
    Configuration menu
    Copy the full SHA
    57065a5 View commit details
    Browse the repository at this point in the history

  4. test: add new unit tests

    @Platonn
    Platonn committed Sep 19, 2024
    Configuration menu
    Copy the full SHA
    449dda1 View commit details
    Browse the repository at this point in the history

  5. revert: formatting multi-line strings in dev mode

    @Platonn
    Platonn committed Sep 19, 2024
    Configuration menu
    Copy the full SHA
    b8b42c1 View commit details
    Browse the repository at this point in the history

  6. fix: in dev mode pretty-print multi-line strings in logs

    @Platonn
    Platonn committed Sep 19, 2024
    Configuration menu
    Copy the full SHA
    fced1fd View commit details
    Browse the repository at this point in the history

  7. chore(manage-dependencies.ts): allow for imports from node-prefixed N… 

    …odeJs APIs, e.g. 'node:fs' (not only 'fs')
    @Platonn
    Platonn committed Sep 19, 2024
    Configuration menu
    Copy the full SHA
    b244963 View commit details
    Browse the repository at this point in the history

  8. Merge branch 'feature/CXSPA-8360' into feature/CXSPA-8385

    @Platonn
    Platonn committed Sep 19, 2024
    Configuration menu
    Copy the full SHA
    6f3e0d7 View commit details
    Browse the repository at this point in the history

Commits on Sep 20, 2024

  1. Merge branch 'develop' of github.com:SAP/spartacus into feature/CXSPA… 

    …-8385
    @Platonn
    Platonn committed Sep 20, 2024
    Configuration menu
    Copy the full SHA
    ff1976e View commit details
    Browse the repository at this point in the history

  2. test: remove redundant copies of tests, after resolving git conflicts

    @Platonn
    Platonn committed Sep 20, 2024
    Configuration menu
    Copy the full SHA
    e271be0 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'develop' into feature/CXSPA-8385

    @Platonn
    Platonn committed Sep 20, 2024
    Configuration menu
    Copy the full SHA
    f07f97a View commit details
    Browse the repository at this point in the history