Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(a11y): Arrow keys navigation for carousel #19168

Merged
merged 2 commits into from
Sep 13, 2024
Merged

Conversation

sdrozdsap
Copy link
Contributor

@sdrozdsap sdrozdsap requested a review from a team as a code owner August 27, 2024 20:20
@github-actions github-actions bot marked this pull request as draft August 27, 2024 20:20
@sdrozdsap sdrozdsap marked this pull request as ready for review August 27, 2024 20:21
Copy link
Contributor

Merge Checks Failed

Please push a commit to re-trigger the build. 
To push an empty commit you can use `git commit --allow-empty -m "Trigger Build"`

@github-actions github-actions bot marked this pull request as draft August 27, 2024 20:21
@sdrozdsap sdrozdsap marked this pull request as ready for review August 28, 2024 06:44
Copy link
Contributor

Merge Checks Failed

Please push a commit to re-trigger the build. 
To push an empty commit you can use `git commit --allow-empty -m "Trigger Build"`

@github-actions github-actions bot marked this pull request as draft August 28, 2024 06:50
@sdrozdsap sdrozdsap marked this pull request as ready for review August 28, 2024 06:51
Copy link
Contributor

Merge Checks Failed

Please push a commit to re-trigger the build. 
To push an empty commit you can use `git commit --allow-empty -m "Trigger Build"`

@github-actions github-actions bot marked this pull request as draft August 28, 2024 06:58
@sdrozdsap sdrozdsap marked this pull request as ready for review August 28, 2024 06:58
Copy link
Contributor

Merge Checks Failed

Please push a commit to re-trigger the build. 
To push an empty commit you can use `git commit --allow-empty -m "Trigger Build"`

@github-actions github-actions bot marked this pull request as draft August 28, 2024 06:59
@sdrozdsap sdrozdsap marked this pull request as ready for review August 28, 2024 07:01
Copy link

cypress bot commented Aug 28, 2024

spartacus    Run #44854

Run Properties:  status check passed Passed #44854  •  git commit bfbeb12c4d ℹ️: Merge 7efa05d4b6b129e736a56fc4acd1818297d4f080 into d03a64a97aa9add2ff95fcbe50a0...
Project spartacus
Branch Review bugfix/CXSPA-7970
Run status status check passed Passed #44854
Run duration 03m 58s
Commit git commit bfbeb12c4d ℹ️: Merge 7efa05d4b6b129e736a56fc4acd1818297d4f080 into d03a64a97aa9add2ff95fcbe50a0...
Committer sdrozdsap
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 3
Tests that did not run due to a developer annotating a test with .skip  Pending 2
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 121
View all changes introduced in this branch ↗︎

@github-actions github-actions bot marked this pull request as draft September 5, 2024 09:35
@sdrozdsap sdrozdsap marked this pull request as ready for review September 5, 2024 09:35
Copy link
Contributor

github-actions bot commented Sep 5, 2024

Merge Checks Failed

Please push a commit to re-trigger the build. 
To push an empty commit you can use `git commit --allow-empty -m "Trigger Build"`

@github-actions github-actions bot marked this pull request as draft September 5, 2024 09:36
@sdrozdsap sdrozdsap marked this pull request as ready for review September 5, 2024 09:37
@github-actions github-actions bot marked this pull request as draft September 12, 2024 07:15
@sdrozdsap sdrozdsap marked this pull request as ready for review September 12, 2024 07:25
@github-actions github-actions bot marked this pull request as draft September 12, 2024 07:57
@sdrozdsap sdrozdsap marked this pull request as ready for review September 12, 2024 07:58
Zeyber
Zeyber previously approved these changes Sep 12, 2024
Copy link
Contributor

Merge Checks Failed

Please push a commit to re-trigger the build. 
To push an empty commit you can use `git commit --allow-empty -m "Trigger Build"`

@github-actions github-actions bot marked this pull request as draft September 13, 2024 06:24
@sdrozdsap sdrozdsap marked this pull request as ready for review September 13, 2024 06:25
@github-actions github-actions bot marked this pull request as draft September 13, 2024 06:58
@sdrozdsap sdrozdsap marked this pull request as ready for review September 13, 2024 06:58
Copy link
Contributor

Merge Checks Failed

Please push a commit to re-trigger the build. 
To push an empty commit you can use `git commit --allow-empty -m "Trigger Build"`

@github-actions github-actions bot marked this pull request as draft September 13, 2024 06:59
@sdrozdsap sdrozdsap marked this pull request as ready for review September 13, 2024 07:12
@sdrozdsap sdrozdsap merged commit 8f15ad0 into develop Sep 13, 2024
28 checks passed
@sdrozdsap sdrozdsap deleted the bugfix/CXSPA-7970 branch September 13, 2024 07:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants