Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[POC] Testing utils for SSR Error Handling #19102

Open
wants to merge 57 commits into
base: develop
Choose a base branch
from
Open

Commits on Jul 10, 2023

  1. fix: 'this' is undefined in ProductEffects.productLoadEffect (#17594)

    Previous behavior: When `/products` endpoint returned a http error, the code broke in [this line](https://github.com/SAP/spartacus/blob/ed1e1a78c488b1e1214491ffa736612287f8cf70/projects/core/src/product/store/effects/product.effect.ts#L77), complaining that `this` is undefined.
    
    Fix: Preserve the context of `this` which was lost in [this line](https://github.com/SAP/spartacus/blob/ed1e1a78c488b1e1214491ffa736612287f8cf70/projects/core/src/product/store/effects/product.effect.ts#L52)
    
    The problem was revealed only after we implemented [CXSPA-2251](https://jira.tools.sap/browse/CXSPA-2251) where we referenced `this` by adding `this.logger` to the method `ProductEffects.productLoadEffect`
    
    fixes https://jira.tools.sap/browse/CXSPA-3902
    Platonn authored and kpawelczak committed Jul 10, 2023
    Configuration menu
    Copy the full SHA
    260f4df View commit details
    Browse the repository at this point in the history

Commits on Jul 25, 2023

  1. feat: handle http errors in ssr (#17624)

    Co-authored-by: Krzysztof Platis <[email protected]>
    Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
    3 people authored Jul 25, 2023
    Configuration menu
    Copy the full SHA
    0357962 View commit details
    Browse the repository at this point in the history

Commits on Aug 7, 2023

  1. Configuration menu
    Copy the full SHA
    038ffdb View commit details
    Browse the repository at this point in the history

Commits on Aug 22, 2023

  1. feat: created effect for handling ngrx errors (#17657)

    Co-authored-by: Krzysztof Platis <[email protected]>
    Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
    3 people authored Aug 22, 2023
    Configuration menu
    Copy the full SHA
    8bba7a6 View commit details
    Browse the repository at this point in the history

Commits on Sep 27, 2023

  1. Merge branch 'develop-6.5.x' into epic/ssr-error-handling

    # Conflicts:
    #	projects/core/src/product/store/actions/product-references.action.ts
    #	projects/core/src/product/store/actions/product-reviews.action.ts
    #	projects/core/src/product/store/effects/product-reviews.effect.ts
    #	projects/core/src/state/utils/entity-loader/entity-loader.action.ts
    kpawelczak committed Sep 27, 2023
    Configuration menu
    Copy the full SHA
    61f9364 View commit details
    Browse the repository at this point in the history
  2. Unit test fixes (#17879)

    kpawelczak authored Sep 27, 2023
    Configuration menu
    Copy the full SHA
    4c7c665 View commit details
    Browse the repository at this point in the history

Commits on Sep 28, 2023

  1. feat: CXSPA-3781 SSR - Multi-provided error interceptors (#17865)

    This pull request introduces methodologies for integrating multiple error interceptors that manage errors within the Server-Side Rendering (SSR) framework. This architectural augmentation preserves backward compatibility, mitigating any potential disruptions for end-users upon the incorporation of new error interceptors into the system.
    
    With the introduction of this enhancement, it becomes easier for users to include new error interceptors, giving them the flexibility to determine the order in which these interceptors are applied within the system. This priority setting allows users to control how these interceptors operate and influence the workflow of the system.
    
    The order is:
    High priority
    Normal or no priority
    Low priority
    
    Preserves the original order within a group of interceptors with the same priority.
    pawelfras authored Sep 28, 2023
    Configuration menu
    Copy the full SHA
    db9157b View commit details
    Browse the repository at this point in the history

Commits on Oct 9, 2023

  1. Configuration menu
    Copy the full SHA
    32d82d6 View commit details
    Browse the repository at this point in the history

Commits on Oct 10, 2023

  1. Configuration menu
    Copy the full SHA
    77e8d8d View commit details
    Browse the repository at this point in the history

Commits on Mar 12, 2024

  1. Configuration menu
    Copy the full SHA
    e432c0a View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    5e09980 View commit details
    Browse the repository at this point in the history

Commits on Mar 25, 2024

  1. remove test.json files

    pawelfras committed Mar 25, 2024
    Configuration menu
    Copy the full SHA
    6074bce View commit details
    Browse the repository at this point in the history

Commits on Mar 26, 2024

  1. Configuration menu
    Copy the full SHA
    0e57246 View commit details
    Browse the repository at this point in the history

Commits on Apr 15, 2024

  1. chore: cleanup

    pawelfras committed Apr 15, 2024
    Configuration menu
    Copy the full SHA
    1a2eb6e View commit details
    Browse the repository at this point in the history

Commits on Apr 16, 2024

  1. Configuration menu
    Copy the full SHA
    ce632d9 View commit details
    Browse the repository at this point in the history

Commits on Apr 18, 2024

  1. Configuration menu
    Copy the full SHA
    f280662 View commit details
    Browse the repository at this point in the history

Commits on Apr 23, 2024

  1. Configuration menu
    Copy the full SHA
    af10432 View commit details
    Browse the repository at this point in the history

Commits on Apr 24, 2024

  1. Configuration menu
    Copy the full SHA
    1c3171a View commit details
    Browse the repository at this point in the history

Commits on Apr 29, 2024

  1. refactor: CXSPA-6598 Remove unused error interceptors and rename MULT…

    …I_ERROR_HANDLERS to singular form (#18776)
    pawelfras authored Apr 29, 2024
    Configuration menu
    Copy the full SHA
    293e579 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    e578194 View commit details
    Browse the repository at this point in the history

Commits on May 6, 2024

  1. Configuration menu
    Copy the full SHA
    082a459 View commit details
    Browse the repository at this point in the history

Commits on Jun 27, 2024

  1. Configuration menu
    Copy the full SHA
    3dbed5a View commit details
    Browse the repository at this point in the history

Commits on Jul 2, 2024

  1. Configuration menu
    Copy the full SHA
    fbc1bc3 View commit details
    Browse the repository at this point in the history

Commits on Jul 5, 2024

  1. Configuration menu
    Copy the full SHA
    065794d View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    91de035 View commit details
    Browse the repository at this point in the history

Commits on Jul 8, 2024

  1. Configuration menu
    Copy the full SHA
    390f50d View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    ab7c3be View commit details
    Browse the repository at this point in the history

Commits on Jul 9, 2024

  1. Configuration menu
    Copy the full SHA
    48f39f0 View commit details
    Browse the repository at this point in the history

Commits on Jul 11, 2024

  1. refactor: revert breaking changes made in #17657 (#19036)

    In the past PR #17657 within this Epic branch, we made a lot of breaking changes. In that past PR we've also renamed public a lot of properties `public payload: any` to `public error: any` which was also a breaking change.
    
    In this PR, we:
    - revert those breaking changes.
      - bring back `public payload` property, if it was renamed to `public error`
      - bring back type `any` for `payload`/`error` properties that were changed to `ErrorActionType`
      - bring back the optional marker (`?`) for `payload`/`error`, that got removed the optional marker (`?`) 
      - bring back the old order of arguments of `EntityScopedFailAction`: `scope, error` vs `error, scope`
    - additionally, we:
      - deprecate the signatures with the optional marker on the `payload`/`error` property, in favor of required params
      - widen type of `payload`/`error` to `any` from too-specific types like `ErrorModel`
      - pass missing `payload`/`error` parameter to super actions (like `ErrorActionType` etc.)
    - fix some unit tests as a result of all above changes
    
    Note for a reviewer:
    The PR #19037 (not meant to be merged!) contains a full diff between this branch and the `develop` branch. You may want to check it to verify the current branch `feature/CXSPA-7198--v2` when merged to `epic/ssr-error-handling` will _really_ help to avoid _all_ breaking changes (related to ngrx actions) against `develop`
    
    fixes https://jira.tools.sap/browse/CXSPA-7198
    Platonn authored Jul 11, 2024
    Configuration menu
    Copy the full SHA
    84de0d1 View commit details
    Browse the repository at this point in the history

Commits on Jul 15, 2024

  1. Configuration menu
    Copy the full SHA
    51a859d View commit details
    Browse the repository at this point in the history

Commits on Jul 17, 2024

  1. Configuration menu
    Copy the full SHA
    031ec7d View commit details
    Browse the repository at this point in the history

Commits on Jul 23, 2024

  1. Configuration menu
    Copy the full SHA
    a1979bc View commit details
    Browse the repository at this point in the history

Commits on Jul 25, 2024

  1. Configuration menu
    Copy the full SHA
    f3348d3 View commit details
    Browse the repository at this point in the history

Commits on Jul 31, 2024

  1. Configuration menu
    Copy the full SHA
    81acc0a View commit details
    Browse the repository at this point in the history

Commits on Aug 2, 2024

  1. Configuration menu
    Copy the full SHA
    f1cc528 View commit details
    Browse the repository at this point in the history

Commits on Aug 5, 2024

  1. Configuration menu
    Copy the full SHA
    f16b8e1 View commit details
    Browse the repository at this point in the history

Commits on Aug 29, 2024

  1. Configuration menu
    Copy the full SHA
    c6d3a7a View commit details
    Browse the repository at this point in the history

Commits on Sep 3, 2024

  1. Configuration menu
    Copy the full SHA
    eeb23f0 View commit details
    Browse the repository at this point in the history
  2. fix: linting issues

    pawelfras committed Sep 3, 2024
    Configuration menu
    Copy the full SHA
    e0356b9 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    253858e View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    177d92b View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    ab5f6c8 View commit details
    Browse the repository at this point in the history
  6. Trigger Build

    pawelfras committed Sep 3, 2024
    Configuration menu
    Copy the full SHA
    69ad454 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    e6b9edc View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    4bb832c View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    c37d81d View commit details
    Browse the repository at this point in the history

Commits on Sep 4, 2024

  1. Configuration menu
    Copy the full SHA
    829f2f6 View commit details
    Browse the repository at this point in the history
  2. refactor after review

    pawelfras committed Sep 4, 2024
    Configuration menu
    Copy the full SHA
    68cab55 View commit details
    Browse the repository at this point in the history
  3. remove unnecessary comment

    pawelfras committed Sep 4, 2024
    Configuration menu
    Copy the full SHA
    8b2a17b View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    e9b6604 View commit details
    Browse the repository at this point in the history
  5. fix typo

    pawelfras committed Sep 4, 2024
    Configuration menu
    Copy the full SHA
    63c15db View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    f5c8343 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    3f72a4b View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    c178d01 View commit details
    Browse the repository at this point in the history

Commits on Sep 5, 2024

  1. Configuration menu
    Copy the full SHA
    de6736e View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    7eba698 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    62d6137 View commit details
    Browse the repository at this point in the history