fix: Fix image lazy loading for Chrome in SSR mode #18761
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 flaky tests on run #43397 ↗︎
Details:
|
|||||||||||||||||||||||||||||||||
| Test | Artifacts | |
|---|---|---|
| Assisted Service Module > Customer Support Agent - Emulation > should checkout as customer |
Test Replay
Screenshots
Video
|
|
ssr/pages.core-e2e.cy.ts • 3 flaky tests • SSR
| Test | Artifacts | |
|---|---|---|
| SSR > should render homepage |
Test Replay
Screenshots
Video
|
|
| SSR > should render PLP |
Test Replay
Screenshots
Video
|
|
| SSR > should render PDP |
Test Replay
Screenshots
Video
|
|
Review all test suite changes for PR #18761 ↗︎
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR provides the work around for not working image lazy loading in SSR in Chrome and Safari.
Issue reported to Angular team angular/angular#55512
QA steps:
1 Scenario
In media.module add
provideDefaultConfig({ imageLoadingStrategy: ImageLoadingStrategy.LAZY } as MediaConfig) to providers
npm run build:storefrontlib && npm run build && npm run build:ssr && NODE_TLS_REJECT_UNAUTHORIZED=0 npm run serve:ssr
Open http://localhost:4000/electronics-spa/en/USD/Brands/Sony/c/brand_5
Check network tab for images, reload page, browser should load only part of images, rest should be loaded on scroll only. Make sure that media component use picture element in html in dev tools
Check Chrome, Safari, Firefox
2 Scenario
In media.module add
provideDefaultConfig({ imageLoadingStrategy: ImageLoadingStrategy.LAZY } as MediaConfig) and provideDefaultConfig({ useLegacyMediaComponent: true } as MediaConfig) to providers
npm run build:storefrontlib && npm run build && npm run build:ssr && NODE_TLS_REJECT_UNAUTHORIZED=0 npm run serve:ssr
Open http://localhost:4000/electronics-spa/en/USD/Brands/Sony/c/brand_5
Check network tab for images, reload page, browser should load only part of images, rest should be loaded on scroll only. Make sure that media component use only img tag (without picture) in html in dev tools
Check Chrome, Safari, Firefox
3 Scenario
Remove provideDefaultConfig({ imageLoadingStrategy: ImageLoadingStrategy.LAZY } as MediaConfig) and provideDefaultConfig({ useLegacyMediaComponent: true } as MediaConfig) from media.module
npm run build:storefrontlib && npm run build && npm run build:ssr && NODE_TLS_REJECT_UNAUTHORIZED=0 npm run serve:ssr
Open http://localhost:4000/electronics-spa/en/USD/Brands/Sony/c/brand_5
Check network tab for images, reload page, browser should load all images
Check Chrome, Safari, Firefox
While checking SSR please make sure that page was rendered by SSR
Perform the same steps in CSR mode
Closes: https://jira.tools.sap/browse/CXSPA-6719