-
Notifications
You must be signed in to change notification settings - Fork 388
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: CXSPA-2066 SSR Error Handling #18742
Commits on Jul 10, 2023
-
fix: 'this' is undefined in ProductEffects.productLoadEffect (#17594)
Previous behavior: When `/products` endpoint returned a http error, the code broke in [this line](https://github.com/SAP/spartacus/blob/ed1e1a78c488b1e1214491ffa736612287f8cf70/projects/core/src/product/store/effects/product.effect.ts#L77), complaining that `this` is undefined. Fix: Preserve the context of `this` which was lost in [this line](https://github.com/SAP/spartacus/blob/ed1e1a78c488b1e1214491ffa736612287f8cf70/projects/core/src/product/store/effects/product.effect.ts#L52) The problem was revealed only after we implemented [CXSPA-2251](https://jira.tools.sap/browse/CXSPA-2251) where we referenced `this` by adding `this.logger` to the method `ProductEffects.productLoadEffect` fixes https://jira.tools.sap/browse/CXSPA-3902
Configuration menu - View commit details
-
Copy full SHA for 260f4df - Browse repository at this point
Copy the full SHA 260f4dfView commit details
Commits on Jul 25, 2023
-
feat: handle http errors in ssr (#17624)
Co-authored-by: Krzysztof Platis <[email protected]> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Configuration menu - View commit details
-
Copy full SHA for 0357962 - Browse repository at this point
Copy the full SHA 0357962View commit details
Commits on Aug 7, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 038ffdb - Browse repository at this point
Copy the full SHA 038ffdbView commit details
Commits on Aug 22, 2023
-
feat: created effect for handling ngrx errors (#17657)
Co-authored-by: Krzysztof Platis <[email protected]> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Configuration menu - View commit details
-
Copy full SHA for 8bba7a6 - Browse repository at this point
Copy the full SHA 8bba7a6View commit details
Commits on Sep 27, 2023
-
Merge branch 'develop-6.5.x' into epic/ssr-error-handling
# Conflicts: # projects/core/src/product/store/actions/product-references.action.ts # projects/core/src/product/store/actions/product-reviews.action.ts # projects/core/src/product/store/effects/product-reviews.effect.ts # projects/core/src/state/utils/entity-loader/entity-loader.action.ts
Configuration menu - View commit details
-
Copy full SHA for 61f9364 - Browse repository at this point
Copy the full SHA 61f9364View commit details -
Configuration menu - View commit details
-
Copy full SHA for 4c7c665 - Browse repository at this point
Copy the full SHA 4c7c665View commit details
Commits on Sep 28, 2023
-
feat: CXSPA-3781 SSR - Multi-provided error interceptors (#17865)
This pull request introduces methodologies for integrating multiple error interceptors that manage errors within the Server-Side Rendering (SSR) framework. This architectural augmentation preserves backward compatibility, mitigating any potential disruptions for end-users upon the incorporation of new error interceptors into the system. With the introduction of this enhancement, it becomes easier for users to include new error interceptors, giving them the flexibility to determine the order in which these interceptors are applied within the system. This priority setting allows users to control how these interceptors operate and influence the workflow of the system. The order is: High priority Normal or no priority Low priority Preserves the original order within a group of interceptors with the same priority.
Configuration menu - View commit details
-
Copy full SHA for db9157b - Browse repository at this point
Copy the full SHA db9157bView commit details
Commits on Oct 9, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 32d82d6 - Browse repository at this point
Copy the full SHA 32d82d6View commit details
Commits on Oct 10, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 77e8d8d - Browse repository at this point
Copy the full SHA 77e8d8dView commit details
Commits on Mar 12, 2024
-
Configuration menu - View commit details
-
Copy full SHA for e432c0a - Browse repository at this point
Copy the full SHA e432c0aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 5e09980 - Browse repository at this point
Copy the full SHA 5e09980View commit details
Commits on Mar 25, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 6074bce - Browse repository at this point
Copy the full SHA 6074bceView commit details
Commits on Mar 26, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 0e57246 - Browse repository at this point
Copy the full SHA 0e57246View commit details
Commits on Apr 15, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 1a2eb6e - Browse repository at this point
Copy the full SHA 1a2eb6eView commit details
Commits on Apr 16, 2024
-
Configuration menu - View commit details
-
Copy full SHA for ce632d9 - Browse repository at this point
Copy the full SHA ce632d9View commit details
Commits on Apr 18, 2024
-
Configuration menu - View commit details
-
Copy full SHA for f280662 - Browse repository at this point
Copy the full SHA f280662View commit details
Commits on Apr 23, 2024
-
Configuration menu - View commit details
-
Copy full SHA for af10432 - Browse repository at this point
Copy the full SHA af10432View commit details
Commits on Apr 24, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 1c3171a - Browse repository at this point
Copy the full SHA 1c3171aView commit details
Commits on Apr 29, 2024
-
refactor: CXSPA-6598 Remove unused error interceptors and rename MULT…
…I_ERROR_HANDLERS to singular form (#18776)
Configuration menu - View commit details
-
Copy full SHA for 293e579 - Browse repository at this point
Copy the full SHA 293e579View commit details -
feat: CXSPA-6578 Introduce PROPAGATE_SERVER_ERROR_RESPONSE and defaul…
…t ExpressJS handlers (#18753)
Configuration menu - View commit details
-
Copy full SHA for e578194 - Browse repository at this point
Copy the full SHA e578194View commit details
Commits on May 6, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 082a459 - Browse repository at this point
Copy the full SHA 082a459View commit details
Commits on Jun 27, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 3dbed5a - Browse repository at this point
Copy the full SHA 3dbed5aView commit details
Commits on Jul 2, 2024
-
Configuration menu - View commit details
-
Copy full SHA for fbc1bc3 - Browse repository at this point
Copy the full SHA fbc1bc3View commit details
Commits on Jul 5, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 065794d - Browse repository at this point
Copy the full SHA 065794dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 91de035 - Browse repository at this point
Copy the full SHA 91de035View commit details
Commits on Jul 8, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 390f50d - Browse repository at this point
Copy the full SHA 390f50dView commit details -
Configuration menu - View commit details
-
Copy full SHA for ab7c3be - Browse repository at this point
Copy the full SHA ab7c3beView commit details
Commits on Jul 9, 2024
-
Revert "feat: update optimized ssr engine tests (#17728)" (#19033)
Co-authored-by: Krzysztof Platis <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 48f39f0 - Browse repository at this point
Copy the full SHA 48f39f0View commit details
Commits on Jul 11, 2024
-
refactor: revert breaking changes made in #17657 (#19036)
In the past PR #17657 within this Epic branch, we made a lot of breaking changes. In that past PR we've also renamed public a lot of properties `public payload: any` to `public error: any` which was also a breaking change. In this PR, we: - revert those breaking changes. - bring back `public payload` property, if it was renamed to `public error` - bring back type `any` for `payload`/`error` properties that were changed to `ErrorActionType` - bring back the optional marker (`?`) for `payload`/`error`, that got removed the optional marker (`?`) - bring back the old order of arguments of `EntityScopedFailAction`: `scope, error` vs `error, scope` - additionally, we: - deprecate the signatures with the optional marker on the `payload`/`error` property, in favor of required params - widen type of `payload`/`error` to `any` from too-specific types like `ErrorModel` - pass missing `payload`/`error` parameter to super actions (like `ErrorActionType` etc.) - fix some unit tests as a result of all above changes Note for a reviewer: The PR #19037 (not meant to be merged!) contains a full diff between this branch and the `develop` branch. You may want to check it to verify the current branch `feature/CXSPA-7198--v2` when merged to `epic/ssr-error-handling` will _really_ help to avoid _all_ breaking changes (related to ngrx actions) against `develop` fixes https://jira.tools.sap/browse/CXSPA-7198
Configuration menu - View commit details
-
Copy full SHA for 84de0d1 - Browse repository at this point
Copy the full SHA 84de0d1View commit details
Commits on Jul 15, 2024
-
feat: CXSPA-6890 Create toggle and optimization options for propagati…
…ng errors to the server (#19021)
Configuration menu - View commit details
-
Copy full SHA for 51a859d - Browse repository at this point
Copy the full SHA 51a859dView commit details
Commits on Jul 17, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 031ec7d - Browse repository at this point
Copy the full SHA 031ec7dView commit details
Commits on Jul 23, 2024
-
chore: CXSPA-7900 Adjust schematics to enable
avoidCachingErrors
op……tion in fresh apps (#19055)
Configuration menu - View commit details
-
Copy full SHA for a1979bc - Browse repository at this point
Copy the full SHA a1979bcView commit details
Commits on Aug 29, 2024
-
Configuration menu - View commit details
-
Copy full SHA for c6d3a7a - Browse repository at this point
Copy the full SHA c6d3a7aView commit details
Commits on Sep 3, 2024
-
Configuration menu - View commit details
-
Copy full SHA for eeb23f0 - Browse repository at this point
Copy the full SHA eeb23f0View commit details -
Configuration menu - View commit details
-
Copy full SHA for e0356b9 - Browse repository at this point
Copy the full SHA e0356b9View commit details -
Configuration menu - View commit details
-
Copy full SHA for 253858e - Browse repository at this point
Copy the full SHA 253858eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 177d92b - Browse repository at this point
Copy the full SHA 177d92bView commit details -
Configuration menu - View commit details
-
Copy full SHA for ab5f6c8 - Browse repository at this point
Copy the full SHA ab5f6c8View commit details -
Configuration menu - View commit details
-
Copy full SHA for 69ad454 - Browse repository at this point
Copy the full SHA 69ad454View commit details -
Configuration menu - View commit details
-
Copy full SHA for e6b9edc - Browse repository at this point
Copy the full SHA e6b9edcView commit details -
Configuration menu - View commit details
-
Copy full SHA for 4bb832c - Browse repository at this point
Copy the full SHA 4bb832cView commit details -
Configuration menu - View commit details
-
Copy full SHA for c37d81d - Browse repository at this point
Copy the full SHA c37d81dView commit details
Commits on Sep 4, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 829f2f6 - Browse repository at this point
Copy the full SHA 829f2f6View commit details -
Configuration menu - View commit details
-
Copy full SHA for 68cab55 - Browse repository at this point
Copy the full SHA 68cab55View commit details -
Configuration menu - View commit details
-
Copy full SHA for 8b2a17b - Browse repository at this point
Copy the full SHA 8b2a17bView commit details -
Configuration menu - View commit details
-
Copy full SHA for e9b6604 - Browse repository at this point
Copy the full SHA e9b6604View commit details -
Configuration menu - View commit details
-
Copy full SHA for 63c15db - Browse repository at this point
Copy the full SHA 63c15dbView commit details -
Configuration menu - View commit details
-
Copy full SHA for f5c8343 - Browse repository at this point
Copy the full SHA f5c8343View commit details -
Configuration menu - View commit details
-
Copy full SHA for 3f72a4b - Browse repository at this point
Copy the full SHA 3f72a4bView commit details -
Configuration menu - View commit details
-
Copy full SHA for c178d01 - Browse repository at this point
Copy the full SHA c178d01View commit details
Commits on Sep 5, 2024
-
Configuration menu - View commit details
-
Copy full SHA for de6736e - Browse repository at this point
Copy the full SHA de6736eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 7eba698 - Browse repository at this point
Copy the full SHA 7eba698View commit details -
Configuration menu - View commit details
-
Copy full SHA for 4e9e6b3 - Browse repository at this point
Copy the full SHA 4e9e6b3View commit details
Commits on Sep 6, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 037445f - Browse repository at this point
Copy the full SHA 037445fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 220537f - Browse repository at this point
Copy the full SHA 220537fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 5ad4961 - Browse repository at this point
Copy the full SHA 5ad4961View commit details
Commits on Sep 9, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 8b0efa5 - Browse repository at this point
Copy the full SHA 8b0efa5View commit details -
Configuration menu - View commit details
-
Copy full SHA for be75da8 - Browse repository at this point
Copy the full SHA be75da8View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0f6a0ac - Browse repository at this point
Copy the full SHA 0f6a0acView commit details -
Configuration menu - View commit details
-
Copy full SHA for 426011d - Browse repository at this point
Copy the full SHA 426011dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 055df22 - Browse repository at this point
Copy the full SHA 055df22View commit details -
Configuration menu - View commit details
-
Copy full SHA for 3f8f3fe - Browse repository at this point
Copy the full SHA 3f8f3feView commit details
Commits on Sep 10, 2024
-
Configuration menu - View commit details
-
Copy full SHA for a9b030a - Browse repository at this point
Copy the full SHA a9b030aView commit details -
Configuration menu - View commit details
-
Copy full SHA for a163637 - Browse repository at this point
Copy the full SHA a163637View commit details -
Configuration menu - View commit details
-
Copy full SHA for 8c36f82 - Browse repository at this point
Copy the full SHA 8c36f82View commit details -
Configuration menu - View commit details
-
Copy full SHA for f129911 - Browse repository at this point
Copy the full SHA f129911View commit details -
Configuration menu - View commit details
-
Copy full SHA for e85a748 - Browse repository at this point
Copy the full SHA e85a748View commit details -
Configuration menu - View commit details
-
Copy full SHA for 42a0662 - Browse repository at this point
Copy the full SHA 42a0662View commit details -
Configuration menu - View commit details
-
Copy full SHA for 18b5091 - Browse repository at this point
Copy the full SHA 18b5091View commit details -
Configuration menu - View commit details
-
Copy full SHA for 5984948 - Browse repository at this point
Copy the full SHA 5984948View commit details -
Configuration menu - View commit details
-
Copy full SHA for 6c9f18f - Browse repository at this point
Copy the full SHA 6c9f18fView commit details -
Configuration menu - View commit details
-
Copy full SHA for bee7cb6 - Browse repository at this point
Copy the full SHA bee7cb6View commit details -
Configuration menu - View commit details
-
Copy full SHA for 03c7454 - Browse repository at this point
Copy the full SHA 03c7454View commit details -
Configuration menu - View commit details
-
Copy full SHA for 8e2bfd8 - Browse repository at this point
Copy the full SHA 8e2bfd8View commit details -
Configuration menu - View commit details
-
Copy full SHA for d56af34 - Browse repository at this point
Copy the full SHA d56af34View commit details -
Configuration menu - View commit details
-
Copy full SHA for aa7a7d0 - Browse repository at this point
Copy the full SHA aa7a7d0View commit details