Skip to content

Use npm workspaces to reuse @sap/cds-mtxs from MTX Sidecar #228

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 9 commits into from
+13,905 −21
Closed

Use npm workspaces to reuse @sap/cds-mtxs from MTX Sidecar #228

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
b9de8d2
Update @sap/cds-dk to 6.8.0
beckermarc May 5, 2023
114eb87
Merge branch 'main' into update-cdsdk-6.8.0
mofterdinger May 5, 2023
3be6b5c
Remove workspace concept to unblock @sap/cds-dk 6.8.0 update
beckermarc May 12, 2023
0344854
Revert "Remove workspace concept to unblock @sap/cds-dk 6.8.0 update"
beckermarc May 12, 2023
6938814
Add required package-lock.json files
beckermarc May 12, 2023
e95cfc8
Use npm ci
beckermarc May 12, 2023
279f229
Merge remote-tracking branch 'origin/main' into use-workspaces
beckermarc May 16, 2023
361ae11
Merge remote-tracking branch 'origin/main' into use-workspaces
beckermarc Jun 20, 2023
bf1da57
Merge remote-tracking branch 'origin/main' into use-workspaces
beckermarc Jul 17, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,6 @@ target/

node/
node_modules/
package-lock.json

.mta/
*.mtar
Expand All @@ -37,4 +36,4 @@ hs_err*
.cdsrc-private.json

/chart/
.reloadtrigger
.reloadtrigger
14 changes: 0 additions & 14 deletions integration-tests/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,20 +74,6 @@
<artifactId>cds-maven-plugin</artifactId>
<version>${cds.services.version}</version>
<executions>
<!-- Following steps start and stop MTX sidecar for tests executed by failsafe plugin -->
<execution>
<id>install-sidecar</id>
<goals>
<goal>npm</goal>
</goals>
<phase>pre-integration-test</phase>
<configuration>
<arguments>install --no-save</arguments>
<skip>${skipTests}</skip>
<workingDirectory>${sidecar.dir}</workingDirectory>
</configuration>
</execution>

<execution>
<id>start-sidecar</id>
<goals>
Expand Down
Loading