Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: bringing lxml latest version. #309

Closed
wants to merge 2 commits into from
Closed

build: bringing lxml latest version. #309

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ae8756d
build: bringing lxml latest version.
awais786 Jun 21, 2022
ed8cb99
build: bringing lxml latest version.
awais786 Aug 19, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@
},
test_suite='tests',
install_requires=[
'lxml<4.7.1',
'lxml<=4.9.0',
Copy link

@andersk andersk Jul 30, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you meant lxml >= 4.9.0 or lxml ~= 4.9 or simply lxml? It makes no sense to allow 4.9.0 but disallow 4.9.1.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am adding pin to avoid any breaking change in any upcoming release. Just update the pin as per new release.

Copy link

@aronbierbaum aronbierbaum Aug 23, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pinning the version like this does not work well for projects using python3-saml. In order for a project to update lxml for a security update you have to wait for a new release of python3-saml. It is a trade off between ensuring that the specified version works and allowing flexibility for users. Ideally we would assume that future versions of lxml work correctly, and make a patch release rejecting certain releases if an issue is identified.

'isodate>=0.6.1',
'xmlsec>=1.3.9'
],
Expand Down