Add missing "await" prefix or "Async" suffix in "async" methods #6787
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IsaacMarovitz
approved these changes
May 14, 2024
marco-carvalho
force-pushed
the
missing_async_await
branch
from
2c8c411
to
3d3f554
Compare
jhorv
reviewed
May 27, 2024
| @@ -59,7 +59,7 @@ public static IMemoryOwner<byte> StreamToRentedMemory(Stream input) | |||
|
|
|||
| public static async Task<byte[]> StreamToBytesAsync(Stream input, CancellationToken cancellationToken = default) | |||
| { | |||
| using MemoryStream stream = MemoryStreamManager.Shared.GetStream(); | |||
| await using MemoryStream stream = MemoryStreamManager.Shared.GetStream(); | |||
There was a problem hiding this comment.
There's no point in async-disposing of a MemoryStream, it just adds overhead around calling Dispose().
jhorv
reviewed
May 27, 2024
| @@ -479,7 +479,7 @@ private async Task UpdateAmiiboPreview(string imageUrl) | |||
| if (response.IsSuccessStatusCode) | |||
| { | |||
| byte[] amiiboPreviewBytes = await response.Content.ReadAsByteArrayAsync(); | |||
| using MemoryStream memoryStream = new(amiiboPreviewBytes); | |||
| await using MemoryStream memoryStream = new(amiiboPreviewBytes); | |||
There was a problem hiding this comment.
As noted elsewhere, async-disposing a MemoryStream only adds overhead.
jhorv
reviewed
May 27, 2024
| @@ -97,7 +97,7 @@ public static string ReadAllText(Assembly assembly, string filename) | |||
|
|
|||
| public async static Task<string> ReadAllTextAsync(Assembly assembly, string filename) | |||
| { | |||
| using var stream = GetStream(assembly, filename); | |||
| await using var stream = GetStream(assembly, filename); | |||
There was a problem hiding this comment.
These Streams returned by GetStream() -> Assembly.GetManifestResourceStream() are based on UnmanagedMemoryStream, and disposing asynchronously only adds overhead.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.