Disable hypervisor by default on macOS

[gdkchan]

Thanks to #6057 and #6356, most performance and compatibility issues with JIT have been fixed. Since some games freezes randomly when using hypervisor, I believe using JIT is a better default on macOS now. This only changes the default setting, people that already has it enabled or disabled will keep their current setting.

It would be nice to get some confirmation that games generally running better on JIT than hypervisor, or in other words, that this is a good change, I'm doing mainly based on reports of people that had better results with JIT.

[github-actions]

Download the artifacts for this pull request:

• ryujinx-Release-1.1.0+4beabb9-linux_arm64
• ryujinx-Release-1.1.0+4beabb9-linux_x64
• ryujinx-Release-1.1.0+4beabb9-macos_universal
• ryujinx-Release-1.1.0+4beabb9-win_x64

Old GUI (GTK3)

• gtk-ryujinx-Release-1.1.0+4beabb9-linux_arm64
• gtk-ryujinx-Release-1.1.0+4beabb9-linux_x64
• gtk-ryujinx-Release-1.1.0+4beabb9-win_x64

GUI-less (SDL2)

• sdl2-ryujinx-headless-Release-1.1.0+4beabb9-linux_arm64
• sdl2-ryujinx-headless-Release-1.1.0+4beabb9-linux_x64
• sdl2-ryujinx-headless-Release-1.1.0+4beabb9-macos_universal
• sdl2-ryujinx-headless-Release-1.1.0+4beabb9-win_x64

Only for Developers

• ryujinx-Debug-1.1.0+4beabb9-linux_arm64
• sdl2-ryujinx-headless-Debug-1.1.0+4beabb9-linux_arm64
• gtk-ryujinx-Debug-1.1.0+4beabb9-linux_arm64
• ryujinx-Debug-1.1.0+4beabb9-linux_x64
• sdl2-ryujinx-headless-Debug-1.1.0+4beabb9-linux_x64
• gtk-ryujinx-Debug-1.1.0+4beabb9-linux_x64
• ryujinx-Debug-1.1.0+4beabb9-macos_universal
• sdl2-ryujinx-headless-Debug-1.1.0+4beabb9-macos_universal
• ryujinx-Debug-1.1.0+4beabb9-win_x64
• sdl2-ryujinx-headless-Debug-1.1.0+4beabb9-win_x64
• gtk-ryujinx-Debug-1.1.0+4beabb9-win_x64

[MutantAura]

Stability wise JIT is much superior but there are still some fairly significant performance delta's to HV.
Tested on base M2 w/ 10 GPU cores

Legends Arceus (Town entrance)
HV: 42FPS
JIT: 34FPS (-19%)

Breath of the Wild (Tested by adding the hv-fix back)
HV: 48FPS
JIT: 42FPS (-12%)

Persona 5 Royal (Station Square)
HV: 75FPS
JIT: 64FPS (-15%)

Tears of the Kingdom (Lookout landing)
HV: 33FPS
JIT: 23FPS (-31%)

Super Mario Oddssey
HV: 101FPS
JIT: 90FPS (-11%)

With that said, the first two games are pretty much unplayable via HV due to freezes so take those results as a best case scenario. The performance hit globally is still quite large, in ToTK in particular it's massive, but the decision I think will swing on what people value more?

[TSRBerry]

Should we ask for opinions before we merge this?

[tgcordell]

A bunch of memory PRs were merged since the last benchmark, so I wanted to test again

Game - TOTK, lookout landing
Ryujinx - 1.1.1293
M1 Pro w/ 16GB ram
HV - 35 fps
JIT - 28 fps (-20%)

IMO - The bigger thing holding back the Ryujinx experience on Mac is the hitching due to shader recompilation, called out in #5713 - but I know thats waiting on a MoltenVK enhancement.

[gdkchan]

Should we ask for opinions before we merge this?

Some people said that games freeze with hypervisor disabled, other said it fixes those issues, so I can only assume it only works for some people based on that, or maybe it is a red herring and doesn't fix the problem at all. So I dunno what is the better default. At least I think the crashes that some games have with hypervisor enabled are consistently fixed.