Change default user creation behavior #6583
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change AccountManager to create a random id for the default user. Change UserEditorView to not show the 'Delete' button if there is only one user present.
Related to Ryujinx#3396 Checks if system/Profiles.json exists, if it does not then prompt the user to manage user profiles.
Current behavior opens the DefaultUserId, however with the change to use a randomly generated ID for the first user there is not a user with that ID. Instead we open the first user in _profiles.
github-actions
bot
added
horizon
ryujinx-mako
bot
requested review from
AcK77,
emmauss,
gdkchan,
TSRBerry and
a team
|
|
||
| await Dispatcher.UIThread.InvokeAsync(async () => | ||
| { | ||
| UserResult result = await ContentDialogHelper.CreateInfoDialog("The default profile has been created.", "Would you like to manage profiles now?", "Yes", "No", "First Launch"); |
There was a problem hiding this comment.
I'm not sure this dialogue is necessary, but if we're keeping it, these strings need to be localised.
There was a problem hiding this comment.
I added the dialog as the issue mentioned a prompt, ideally I would have wanted to display a version of the user editor right away, but I am very new to UI related things. I do agree that in its current state it is unnecessary/clunky.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This resolves #3396. Changed the way that AccountManager creates the first user. Instead of creating a user if one with the DefaultUserId does not exists, it now creates a user if the profiles dictionary is empty. And when creating that user it uses a randomly generated user id instead of the fixed default. Also added a prompt on the first launch (technically if system/Profiles.json does not exist) which will ask the user if they wish to manage user profiles immediately.
Sidenote:
This is my first time contributing to an open source project, so I apologize if I have failed to follow any etiquette. In addition, I also apologize if the solution to the issue is not appropriate. I would appreciate any feedback anyone may have.