[WIP] mcf: Modular Crypt Format implementation #1855
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tarcieri
force-pushed
the
mcf
branch
2 times, most recently
from
ce29209 to
ff1e5c2
Compare
tarcieri
commented
Jun 3, 2025
Comment on lines
+58
to
+59
| /// Get an iterator over the parts of the password hash as delimited by `$`, including the | ||
| /// initial identifier. |
There was a problem hiding this comment.
Perhaps it shouldn't include the initial identifier?
For more information on the format, see: <https://passlib.readthedocs.io/en/stable/modular_crypt_format.html>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initial implementation of the MCF pseudo-format as described at: https://passlib.readthedocs.io/en/stable/modular_crypt_format.html
Note that MCF is less a specification than an ad hoc set of conventions.
As MCF lacks the kind of rigidly specified sizes of its various components, a heapless
no_stdimplementation isn't really possible like it is with the PHC format, and so this implementation has a hard dependency onalloc(though it should be possible to extract analloc-free reference type which borrows from its input).