Support CI tests for old rust-gpu versions
#41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tombh
force-pushed
the
support-ci-testing-old-rust-gpu-versions
branch
from
36394d5 to
0e50a9b
Compare
|
BTW I streamed a lot of the development of this PR on Twitch 🤓 https://www.twitch.tv/videos/2365066223 |
tombh
force-pushed
the
support-ci-testing-old-rust-gpu-versions
branch
2 times, most recently
from
23ab263 to
a27320a
Compare
tombh
force-pushed
the
support-ci-testing-old-rust-gpu-versions
branch
from
a27320a to
22389d6
Compare
Adds `rust-gpu` versions, `0.8.0` and `0.9.0` to the Linux matrix on CI tests. `0.7.0` has a probably minor dependency error, but it's also 18 months old and there probably aren't many users of it. Notes: * Adds a version arg to: `just build-shader-template 0.8.0`. * Offers a new CLI arg to workaround a bug where conflicting v3/v4 versions of `Cargo.lock` files (between the shader and workspace) cause a build error. See `force_overwrite_lockfiles_v4_to_v3` arg.
tombh
force-pushed
the
support-ci-testing-old-rust-gpu-versions
branch
from
22389d6 to
ad2397d
Compare
|
This is ready for review. There's still a couple of TODOs, but they're not high priority. |
|
@tombh do you want me to clear up these conflicts, since I ultimately caused them? |
|
Aww, thanks for the offer! Very kind of you 😊 I was actually more interested in a review at the moment. Then I could make any changes and resolve the conflicts at once. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds
rust-gpuversions,0.8.0and0.9.0to the Linux matrix on CI tests.0.7.0has a probably minor dependency error, but it's also 18 months old and there probably aren't many users of it.Notes:
just build-shader-template 0.8.0.Cargo.lockfiles (between the shader and workspace) cause a build error. Seeforce_overwrite_lockfiles_v4_to_v3argspirv-stdin theshader-crate-template.TODO:
Cargo.lockfiles that need to be reverted. This will allow reverting them even if the build fails.Cargo.lockmanifest version conflict. It would require having a sample shader crate with a Rust toolchain is < 1.83.0.