nr2.0: Adjust alternate identifier handling #3821
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gcc/rust/ChangeLog: * resolve/rust-late-name-resolver-2.0.cc (visit_identifier_as_pattern): Make sure to map identifiers inside or-bindings to prior identifiers. Signed-off-by: Owen Avery <[email protected]>
CohenArthur
reviewed
Jun 11, 2025
Comment on lines
+239
to
+241
| auto res = ctx.values.get (ident); | ||
| rust_assert (res.has_value () && !res->is_ambiguous ()); | ||
| ctx.map_usage (Usage (node_id), Definition (res->get_node_id ())); |
There was a problem hiding this comment.
don't we need to sometimes insert a shadowable name when resolving identifier patterns? e.g.
struct Foo(i32);
match foo {
Foo(a) => { use(a) },
}or am I misunderstanding?
There was a problem hiding this comment.
let Foo(a | a) = x;
^ ^
| |_ 'a' is or-bound, map to last definition
|_ 'a' is not or-bound, insert definition (see 'else' block)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.