Skip to content

Fix activity label contrast #745

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jakeob28
Copy link
Contributor

@jakeob28 jakeob28 commented Jun 9, 2025

When logged in as an instructor, currently portions of the activity labels currently have insufficient contrast per WCAG guidelines:
image

This PR fixes this by using italics instead of reduced opacity to indicate the activity identifier:
image

Let me know if you'd prefer a different method (other than italics) of indicating the assignment identifier. One alternative is just to use the parenthesis without any additional styling, which would look like:
image
or bolding the rest of the caption:
image

@jakeob28 jakeob28 requested a review from bnmnetp as a code owner June 9, 2025 23:44
@bnmnetp
Copy link
Member

bnmnetp commented Jun 10, 2025

So we made them very light because many instructors find them distracting and unsightly. I wonder if there is a way to satisfy WCAG guidelines while not drawing attention to them.

@pearcej
Copy link

pearcej commented Jun 10, 2025

What about parentheses and right justification, so it is out of the top-left primary viewing area?
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants