RUN-43 #727
Open
RUN-43 #727
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ercise creation page entries for difficulty and points. Fix plus icon hiding in assignment exercises table.
morozov-av
reviewed
May 26, 2025
| @@ -161,7 +161,7 @@ export const BaseExerciseSettingsContent = <T extends BaseExerciseSettings>({ | |||
| min={1} | |||
| max={5} | |||
| className="w-full" | |||
| onValueChange={(e) => updateSetting("difficulty", e.value !== null ? e.value : 3)} | |||
| onChange={(e) => updateSetting("difficulty", e.value !== null ? e.value : 1)} | |||
There was a problem hiding this comment.
Please avoid code duplication. create a separate function inside the component and use it in both places
morozov-av
reviewed
May 26, 2025
| @@ -20,24 +20,13 @@ export const exercisesApi = createApi({ | |||
| createNewExercise: build.mutation<number, CreateExercisesPayload>({ | |||
| query: (body) => ({ | |||
| method: "POST", | |||
| url: "/assignment/instructor/new_question", | |||
| url: "/assignment/instructor/question_creation", | |||
There was a problem hiding this comment.
Would it be better to call the endpoint just POST /assignment/instructor/question ?
I assume the HTTP POST method already gives a clear idea of what we're doing here. What do you think, @bnmnetp ?
There was a problem hiding this comment.
I agree that it's better. Renamed it in the new commit
…ssary import. Remove code duplication in BaseExerciseSettingsContent.tsx
|
Sorry for letting this linger. I think the conflicts should be easy to resolve and then I will get this merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix wrong difficulty and points values in exercise creation. Update exercise creation page entries for difficulty and points. Fix plus icon hiding in assignment exercises table.