Changed our recipe hash into a hash that that describes a Train.#8
Open
adamxlowe wants to merge 3 commits intoRubyoffRails:masterfrom
adamxlowe:master
Open
Changed our recipe hash into a hash that that describes a Train.#8adamxlowe wants to merge 3 commits intoRubyoffRails:masterfrom adamxlowe:master
adamxlowe wants to merge 3 commits intoRubyoffRails:masterfrom
adamxlowe:master
Conversation
Member
|
Looks great. I do think this exercise shows one note: train = Train.new("Los Angeles", 1, 15, 1)Looking at this method, its extremely hard to tell what is what. We can change this to this for readability: train = Train.new("Los Angeles", engines=1, cars=15, caboose=1)thoughts? |
Author
|
It does make reading it a lot more clear. Thank you. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.