Panda + Tiger + Eagle #7
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -3,22 +3,47 @@ | |||
| require "ostruct" | |||
| require_relative "./movie" | |||
| class Api | |||
| @@search_history = [] | |||
There was a problem hiding this comment.
I don't like class variables in most cases... This will prevent you from going multi-threaded in the future (as each thread will overwrite this variable)
There was a problem hiding this comment.
Thanks, that is a left over artifact from before I implemented the Search_History class.
|
Good stuff here! I especially love the way the search_history class ended up looking... Looks great (small methods, readable, clean). One minor note --- I found that if I had some valid searches, and then mispelled a classic (Billy Maddison), it would use 0 as a score and drop my movie score |
|
Thank you for your great suggestions. I will add a test for the NOTHINGFOUNDHERE score bug. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I still need to refactor my test, but i hope to go over that in the office hour if you don't already have a plan.