Initial attempt at both Panda Levels and Tiger L-1

[codeblahblah]

@jwo Had to @another_battleship = Battleship.new as I could not assert_equal on a Mock object.
Also refactored TestBattleship by adding a #setup.
Am I green enough to continue with the rest of the assignment?

[jwo]

Sure, looks great to me. (Though you don't need to ask my permission to continue)

[codeblahblah]

Thanks. Will keep that in mind in future.

[codeblahblah]

@jwo Add syntax to confirm that the Battleship can request more ammunition

[codeblahblah]

@jwo I used a Module instead of a Class for "Fate".

[jwo]

I don't see you ever use the "FATE" constant. Is there a significance around it?

[codeblahblah]

@jwo Refactored code.

[codeblahblah]

@jwo Is a Module the correct way to go about the assignment?

[jwo]

It could be -- I don't dislike the approach.

On Thu, Feb 13, 2014 at 1:51 PM, drammopo [email protected]
wrote:

@jwo Is a Module the correct way to go about the assignment?

Reply to this email directly or view it on GitHub:
#7 (comment)

[codeblahblah]

@jwo Any other way? Can I consider the assignment complete?

[jwo]

This does not seem complete, thoughts?

[codeblahblah]

@jwo Having never played battleship...I had to read up on the rules.
Changed from

  def has_a_ship?
    true
  end 

to

   def has_a_ship?
    @battleship.max_hits > 0
  end 

[jwo]

hmm, well you're not using has_a_ship as a counter. You're using it in a test:

def test_have_a_battleship
  assert_equal true, @another_admiral.has_a_ship?
end

[codeblahblah]

@jwo I'm now using the @max_hits of the Battleship for the test.

[jwo]

OK, sounds good. nothing else I have to comment on.