Conversation
Member
There was a problem hiding this comment.
one final recommendation (this is a new one of mine) --- if you have an attr_reader for ammunition_reserves, it works well to only refer to it by the ammunition_reserves method.
if amount <= ammunition_reservesWhy? Because later you can move ammunition_reserves from an instance variable to another object... And you could
def ammunition_reserves
Reserves.calculate_ammunition(self)
endand the request_ammunition method wouldn't know the difference.
Member
|
Most excellent job! Great job on the course. For this episode --- which did you like better? MiniTest or RSpec? |
Author
|
RSpec syntax makes more sense to me. It was interesting to work with both, but hard to switch back and forth in the same project. I need to try working with the new RSpec expect syntax. I think I'd like it more then the should syntax. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.