panda + tiger + eagle without complete test#28
Open
lww wants to merge 3 commits intoRubyoffRails:masterfrom
lww:master
Open
panda + tiger + eagle without complete test#28lww wants to merge 3 commits intoRubyoffRails:masterfrom lww:master
lww wants to merge 3 commits intoRubyoffRails:masterfrom
lww:master
Conversation
Member
|
hi! So, take a look at this Pull request -- it's telling you that the Build failed because the tests no longer pass. Rather than going back and adding tests later, you'll need to at least make the existing suite pass. |
Member
There was a problem hiding this comment.
Rather than two methods, one names "end_status" and one named "pre_status", I think you should have 1 method "status" that returns different data based on its game state
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I will update tests later. For me it's very hard to think test first...