Open
Conversation
Member
|
Hi @brittknee --- there are some test failures in the code (https://travis-ci.org/RubyoffRails/Episode1-Summer2012/builds/5169528). Do you want to work on those and resubmit with passing tests? I'll add some feedback right now, but I'd like the tests to pass 😄 |
Member
|
Your code looks excellent. excellent! |
Author
|
@jwo - I just updated the code so the tests are now passing - I need to get in the habit of checking that first - haha. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I modified the Game api to restrict access to the dealer_hand and player_hand attributes in the Eagle level. I did not want to allow access to those attributes from outside the class - not sure if that is a good design decision or not.
In the Tiger level I struggled with the best way to structure the test (line 236) - I attempted a mock but couldn't get it to work for me.
I'd love some feedback on my code and if there would have been a better way to approach things.
Thanks!