Warn when using #eql?
on zero amounts with different currencies
#1155
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1122
With this change comparing two zero amounts with different currencies using
#eql?
triggers a warning:To disable this warning, opt-in to the new behavior so that it always does a strict comparison:
I’m guessing that using a configuration to opt-in can help ease into this new behavior, but I’m not sure this would be the best way to introduce this both a warning and a config. Happy for feedback about this.