Skip to content

Silence deprecation warning in specs #1154

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

sunny
Copy link
Contributor

@sunny sunny commented Jul 25, 2025

Before:

Randomized with seed 53114
.........................................................................................................................................[WARNING] Using :ruby format when importing rates is potentially unsafe and might lead to remote code execution via Marshal.load deserializer. Consider using safe alternatives such as :json and :yaml.
...........................................................................................................................................................................................................................................................................................................................................................................................

After:

Randomized with seed 30224
....................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................

Also moved a few RSpec configuration into their own support files in order to have a more readable RSpec configuration.

Comment on lines +22 to +24
class Money::Bank::VariableExchange
include Money::Warning
end
Copy link
Contributor Author

@sunny sunny Jul 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the include that silences the current warn in the specs.

@sunny sunny changed the title Specs: Silence deprecation warning Silence deprecation warning in specs Jul 25, 2025
Before:

> Randomized with seed 53114
> .........................................................................................................................................[WARNING] Using :ruby format when importing rates is potentially unsafe and might lead to remote code execution via Marshal.load deserializer. Consider using safe alternatives such as :json and :yaml.
> ...........................................................................................................................................................................................................................................................................................................................................................................................

After:

> Randomized with seed 30224
> ....................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................

Also moved a few RSpec configuration into their own support files in order to have a more readable RSpec configuration.
@sunny sunny force-pushed the silence-spec-warning branch from c658937 to 4595f6c Compare July 25, 2025 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant