Fix for Rubjerg/Graphviz.NetWrapper 115#116
Merged
chtenb merged 2 commits intoRubjerg:masterfrom Feb 12, 2026
Merged
Conversation
chtenb
reviewed
Feb 12, 2026
Rubjerg.Graphviz/GraphvizCommand.cs
Outdated
| return possibleLocations.Select(dir => Path.Combine(dir, "dot")).FirstOrDefault(File.Exists) | ||
| ?? possibleLocations.Select(dir => Path.Combine(dir, "dot.exe")).FirstOrDefault(File.Exists) | ||
| return possibleLocations.Where(d => !string.IsNullOrWhiteSpace(d)).Select(dir => Path.Combine(dir, "dot")).FirstOrDefault(File.Exists) | ||
| ?? possibleLocations.Where(d => !string.IsNullOrWhiteSpace(d)).Select(dir => Path.Combine(dir, "dot.exe")).FirstOrDefault(File.Exists) |
Member
There was a problem hiding this comment.
This also checks for whitespace or empty strings, which is overly defensive. In fact, on list 44 we purposefully have an empty string as location, which resolves to the working directory of the process. I think we should only eliminate actual null values. Is that indeed enough to solve the issue you are encountering?
Contributor
Author
There was a problem hiding this comment.
makes sense. updated it to null check only
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduces a null check to confirm that the directories, which are getting verified, are not null