Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move tools to a separate directory #316

Open
wants to merge 5 commits into
base: 3.0
Choose a base branch
from

Conversation

mcharytoniuk
Copy link
Member

The goal is to avoid dependencies between tools.

For example the latest phpstan and the latest phpunit depend on a different version of https://github.com/sebastianbergmann/diff

Also it won't cause as many potential dependency conflicts between RubixML and the end user projects.

I modified composer.json, so scripts should work exactly as before (for example composer anayze runs phpstan).

I made an exception for phpunit, so phpstan can still analyze the test files.

Next step would be to also add https://github.com/rectorphp/rector to the tools directory and update phpunit to v11 (tbd in a different PR)

@andrewdalpino
Copy link
Member

Is this solving a problem that we have currently? Or a potential one in the future?

@mcharytoniuk
Copy link
Member Author

mcharytoniuk commented Feb 12, 2024

@andrewdalpino it solves the current problem: I can't use the latest PHPUnit version alongside the latest PHPStan because they conflict with the required https://github.com/sebastianbergmann/diff library version.

I want to upgrade PHPUnit, because the current version reaches EOL in the February (at least end of bugfix support): https://phpunit.de/supported-versions.html

I'm just stuck in a dependency hell - I wanted to decouple all those tooling dependencies from the core codebase. :D

@andrewdalpino andrewdalpino requested review from andrewdalpino and a team February 23, 2024 16:58
Copy link
Member

@andrewdalpino andrewdalpino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As long as this doesn't effect the installability via composer require rubix/ml then I think we're good to go

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants