#86c0b8vp3: Impement Sentry generator using ast #50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RuslanAktaev
changed the title
|
@dmitryusenko review please! FYI @ipakhomov |
dmitryusenko
reviewed
Nov 1, 2024
| "withSentry": { | ||
| "type": "boolean", | ||
| "default": false, | ||
| "x-prompt": "Do you want to use sentry in your app?" |
There was a problem hiding this comment.
Suggested change
| "x-prompt": "Do you want to use sentry in your app?" | |
| "x-prompt": "Do you want to use Sentry in your app?" |
dmitryusenko
reviewed
Nov 1, 2024
| "withSentry": { | ||
| "type": "boolean", | ||
| "default": false, | ||
| "x-prompt": "Do you want to use sentry in your app?" |
There was a problem hiding this comment.
Suggested change
| "x-prompt": "Do you want to use sentry in your app?" | |
| "x-prompt": "Do you want to use Sentry in your app?" |
dmitryusenko
reviewed
Nov 1, 2024
| import * as Sentry from '@sentry/nextjs'; | ||
|
|
||
| Sentry.init({ | ||
| dsn: '<%= DSN %>', |
There was a problem hiding this comment.
Suggested change
| dsn: '<%= DSN %>', | |
| dsn: '<%= dsn %>', |
dmitryusenko
reviewed
Nov 1, 2024
| import * as Sentry from '@sentry/nextjs'; | ||
|
|
||
| Sentry.init({ | ||
| dsn: '<%= DSN %>', |
There was a problem hiding this comment.
Suggested change
| dsn: '<%= DSN %>', | |
| dsn: '<%= dsn %>', |
dmitryusenko
reviewed
Nov 1, 2024
| import * as Sentry from '@sentry/nextjs'; | ||
|
|
||
| Sentry.init({ | ||
| dsn: '<%= DSN %>', |
There was a problem hiding this comment.
Suggested change
| dsn: '<%= DSN %>', | |
| dsn: '<%= dsn %>', |
dmitryusenko
reviewed
Nov 1, 2024
| export interface SentryGeneratorSchema { | ||
| name: string; | ||
| directory: string; | ||
| DSN: string; |
There was a problem hiding this comment.
Suggested change
| DSN: string; | |
| dsn: string; |
dmitryusenko
reviewed
Nov 1, 2024
| }, | ||
| "x-prompt": "Enter the name of the directory in the 'apps/' folder (e.g: web)" | ||
| }, | ||
| "DSN": { |
There was a problem hiding this comment.
Suggested change
| "DSN": { | |
| "dsn": { |
dmitryusenko
reviewed
Nov 1, 2024
| }, | ||
| ); | ||
|
|
||
| const updateExtraConfig = (content: string, DSN: string): string => |
There was a problem hiding this comment.
Suggested change
| const updateExtraConfig = (content: string, DSN: string): string => | |
| const updateExtraConfig = (content: string, dsn: string): string => |
dmitryusenko
reviewed
Nov 1, 2024
| initializer: factory.createObjectLiteralExpression([ | ||
| factory.createPropertyAssignment( | ||
| 'dsn', | ||
| factory.createStringLiteral(DSN), |
There was a problem hiding this comment.
Suggested change
| factory.createStringLiteral(DSN), | |
| factory.createStringLiteral(dsn), |
dmitryusenko
reviewed
Nov 1, 2024
|
|
||
| const updatedAppConfigContent = updateExtraConfig( | ||
| addSentryPluginToAppConfig(appConfigContent), | ||
| options.DSN, |
There was a problem hiding this comment.
Suggested change
| options.DSN, | |
| options.dsn, |
dmitryusenko
reviewed
Nov 1, 2024
Comment on lines
+109
to
+117
| const nextConfigContent = tree | ||
| .read(`${projectRoot}/next.config.js`) | ||
| .toString(); | ||
|
|
||
| const updatedNextConfigContent = wrapIntoSentryConfig( | ||
| modifyNextConfig(addRequiredImports(nextConfigContent)), | ||
| ); | ||
|
|
||
| tree.write(`${projectRoot}/next.config.js`, updatedNextConfigContent); |
There was a problem hiding this comment.
We could implement some utility function to shorten the code that performs such file updates. Very rough idea:
// UTILITY DEFINITION
function updateFile(tree, filePath, updater) {
// 1. Call tree.read to get file contents
// 2. Call updater over the file contents
// 3. Call tree.write to write the updated file contents
}
// USAGE
updateFile(
tree,
`${projectRoot}/next.config.js`,
(content) => wrapIntoSentryConfig(modifyNextConfig(addRequiredImports(content)))
);This way we eliminate some code duplication, and also get rid of unnecessary variable declarations.
dmitryusenko
requested changes
Nov 1, 2024
There was a problem hiding this comment.
@RuslanAktaev Looks good to me overall! I've provided the feedback above. Could you please address it?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.