feat: set up project to use Paratest #136
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@DenTray Could you please review this one? |
DenTray
requested changes
Oct 14, 2024
src/Drivers/BaseDriver.php
Outdated
| rewind($handle); | ||
| fwrite($handle, json_encode($data, JSON_THROW_ON_ERROR)); | ||
|
|
||
| flock($handle, LOCK_UN); |
There was a problem hiding this comment.
Suggested change
| flock($handle, LOCK_UN); | |
| fclose($handle); |
src/Drivers/BaseDriver.php
Outdated
Comment on lines
31
to
41
| $handle = @fopen($this->tempFilePath, 'r'); | ||
|
|
||
| return json_decode($content, true); | ||
| if ($handle === false) { | ||
| return null; | ||
| } | ||
|
|
||
| return null; | ||
| flock($handle, LOCK_SH); | ||
|
|
||
| $content = stream_get_contents($handle); | ||
|
|
||
| return json_decode($content, true); |
There was a problem hiding this comment.
let's move all low-level code to the separate function
$content = $this->getFileContentWithLock($this->tempFilePath);
return json_decode($content, true);
src/Drivers/BaseDriver.php
Outdated
| } | ||
|
|
||
| public function getTmpData(): ?array | ||
| { | ||
| if (file_exists($this->tempFilePath)) { | ||
| $content = file_get_contents($this->tempFilePath); | ||
| $handle = @fopen($this->tempFilePath, 'r'); |
There was a problem hiding this comment.
let's use try catch instead
…in different workers;
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Done: