Merge pull request #125 from RonasIT/fix-missed-empty-responses-defin…

…itions fix: missed response definition when the content of response was empty
RonasIT · May 2, 2024 · 4c3a0c9 · 4c3a0c9
2 parents d42ab6c + 555604e
commit 4c3a0c9
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 7 deletions.
diff --git a/src/Services/SwaggerService.php b/src/Services/SwaggerService.php
@@ -296,14 +296,10 @@ protected function markAsDeprecated(array $annotations)
 
     protected function saveResponseSchema(?array $content, string $definition): void
     {
-        if (empty($content)) {
-            return;
-        }
-
         $schemaProperties = [];
         $schemaType = 'object';
 
-        if (array_is_list($content)) {
+        if (!empty($content) && array_is_list($content)) {
             $this->saveListResponseDefinitions($content, $schemaProperties);
 
             $schemaType = 'array';
@@ -366,7 +362,7 @@ protected function parseResponse($response)
 
         $responseExampleLimitCount = config('auto-doc.response_example_limit_count');
 
-        $content = json_decode($response->getContent(), true);
+        $content = json_decode($response->getContent(), true) ?? [];
 
         if (!empty($responseExampleLimitCount)) {
             if (!empty($content['data'])) {

diff --git a/tests/fixtures/SwaggerServiceTest/tmp_data_put_user_request_with_early_generated_doc.json b/tests/fixtures/SwaggerServiceTest/tmp_data_put_user_request_with_early_generated_doc.json
@@ -103,7 +103,7 @@
           "204": {
             "description": "Operation successfully done",
             "schema": {
-              "example": null,
+              "example": [],
               "$ref": "#/definitions/patchUsers{id}204ResponseObject"
             }
           }
@@ -141,6 +141,10 @@
         "query": null
       },
       "required": ["query"]
+    },
+    "patchUsers{id}204ResponseObject": {
+      "type": "object",
+      "properties": []
     }
   },
   "info": {