[293]: delete deprecated SearchTrait methods, update visibility - #294
Merged
Conversation
added 3 commits
June 16, 2026 20:22
vitgrams
approved these changes
Jun 17, 2026
DenTray
reviewed
Aug 24, 2026
Comment on lines
+283
to
+288
| $this->callEncapsulatedMethod($this->testRepositoryClass, 'setAdditionalReservedFilters', | ||
| 'date_greater', | ||
| 'date_less', | ||
| 'updated_at_greater', | ||
| 'updated_at_less', | ||
| ); |
Collaborator
There was a problem hiding this comment.
Code style: php-cs-fixer with the project config reports this file as fixable.
Reproduce: PHP_CS_FIXER_IGNORE_ENV=1 vendor/bin/php-cs-fixer fix --config=.php-cs-fixer.dist.php --dry-run --diff tests/SearchTraitTest.php
Suggested change
| $this->callEncapsulatedMethod($this->testRepositoryClass, 'setAdditionalReservedFilters', | |
| 'date_greater', | |
| 'date_less', | |
| 'updated_at_greater', | |
| 'updated_at_less', | |
| ); | |
| $this->callEncapsulatedMethod( | |
| $this->testRepositoryClass, | |
| 'setAdditionalReservedFilters', | |
| 'date_greater', | |
| 'date_less', | |
| 'updated_at_greater', | |
| 'updated_at_less', | |
| ); |
| ->filterLessThan('updated_at', Carbon::now()) | ||
| ->filterGreater('date', false, 'date_greater') | ||
| ->filterLess('date', false, 'date_less') | ||
| ->filterValue('created_at', '>=', Carbon::now()) |
Collaborator
There was a problem hiding this comment.
Nit: testSearchQueryWithFiltersFunctions now largely overlaps with testSearchQueryWithFilters above: same SQL mock, same expected query, the only difference being explicit chaining vs. filter-name suffixes. The genuinely new coverage here is filterValue(). Consider renaming to something like testSearchQueryWithChainedFilters to make the distinction clear.
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
DenTray
approved these changes
Aug 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
refs: #293