[289]: add table prefix to SearchTrait filterByQuery - #292
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 1e0f80f0c9
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
|
@DenTray Note: It looks like we have a similar bug in our filters that use the However, this issue will only surface when using joins or a global scope with a join, so it might not be critical for our current use cases. Perhaps some non-trivial custom relation (hasManyThrough) where it will be ambiguous. It's probably best to open a separate ticket for this if we have run into similar problems before. An ambiguous column in Postgres means 2+ tables in the same FROM clause on the same level, both containing this column. Correlation with an outer table doesn't count here - it is on a different level and loses precedence to the inner table. |
refs: #289