docs: improve service-repository architecture description in readme - #268
docs: improve service-repository architecture description in readme#268artengin wants to merge 28 commits into
Conversation
…method signatures
…ory-architecture-docs
|
@codex review |
|
Codex Review: Didn't find any major issues. Keep it up! ℹ️ About Codex in GitHubCodex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback". |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 0c31f23670
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
…pagination details
…ory-architecture-docs
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 31255e4a69
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| /** | ||
| * Update multiple entities by condition | ||
| */ | ||
| public function updateMany(array $where, array $data): int |
There was a problem hiding this comment.
When callers use the previously supported primary-key shorthand, e.g. updateMany(1, ['name' => ...]), this new array parameter type throws a TypeError before getQuery() can normalize the scalar into a primary-key condition. The old method accepted condition or primary key values, and the removed test covered this exact scalar case, so this breaks existing repository users who update by id through updateMany.
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 5e5808de45
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| /** | ||
| * Count entities by condition | ||
| */ | ||
| public function count(array $where = []): int |
There was a problem hiding this comment.
When callers use the previously accepted primary-key shorthand, e.g. count(1), this new array parameter type throws a TypeError before getQuery()/constructWhere() can normalize the scalar into a primary-key condition. Since the underlying query builder path still supports scalar conditions and other repository condition methods continue to accept them, service/repository consumers counting a single id now fail instead of returning the expected 0/1 count.
Useful? React with 👍 / 👎.
2 participants
refs: #267