[252]: add DB type range validation rule by vitgrams · Pull Request #253 · RonasIT/laravel-helpers

vitgrams · 2026-03-11T10:56:48Z

refs: #252

vitgrams · 2026-03-11T18:42:57Z

@yburlakov Please review these changes

vitgrams · 2026-03-12T09:51:04Z

@yburlakov Fixed review remarks

Copilot

Pull request overview

Adds a new Laravel validation rule (db_type_range) intended to validate request values against predefined min/max ranges derived from DB column data types (with a default PostgreSQL type range map), and registers it for string-rule usage via the package service provider.

Changes:

Introduces DbTypeRangeRule (implements ValidationRule) that validates either numeric ranges or string length ranges based on a type→range map.
Adds a default PostgreSQL type range map via PostgresDatabaseTypeEnum implementing DatabaseTypeRangesContract, bound in HelpersServiceProvider.
Extends ValidatorTest with new coverage for the rule (pass/fail cases, missing/unknown type handling, object syntax).

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 6 comments.

Show a summary per file

File	Description
tests/ValidatorTest.php	Adds tests for the new `db_type_range` validator and object rule usage.
src/Rules/DbTypeRangeRule.php	Implements the core range validation logic using a container-resolved ranges provider.
src/HelpersServiceProvider.php	Registers the `db_type_range` string rule and binds the default ranges provider.
src/Enums/PostgresDatabaseTypeEnum.php	Defines the default Postgres type→range mapping.
src/Contracts/DatabaseTypeRangesContract.php	Adds the contract for providing type→range mappings.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

… length refs: #252 Comment: #253 (comment)

…asses" cases; refs: #252 Comment: #253 (comment)

refs: #252 Comment: #253 (comment)

…rt resolver refs: #252

refs: #252

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: dea6e14fd1

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

chatgpt-codex-connector · 2026-05-28T09:28:13Z

+
+    protected function validateInteger(string $attribute, mixed $value, mixed $min, mixed $max, Closure $fail): void
+    {
+        if (!preg_match(self::INTEGER_PATTERN, (string) $value)) {


Guard non-scalar integer inputs before casting

When an integer-backed rule receives a non-scalar value, such as a request array for db_type_range:integer, this cast runs before validation can fail normally. (string) ['foo'] emits an Array to string conversion warning, which Laravel/PHPUnit error handling commonly turns into an exception, and objects without __toString() throw immediately; those inputs should produce the integer validation error instead of crashing the validator.

Useful? React with 👍 / 👎.

good point! fixed

refs: #252

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: da9c0e9d1f

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

chatgpt-codex-connector · 2026-05-28T10:00:17Z

+
+    protected function validateInteger(string $attribute, mixed $value, mixed $min, mixed $max, Closure $fail): void
+    {
+        if (!is_scalar($value) || !preg_match(self::INTEGER_PATTERN, (string) $value)) {


Reject booleans before integer range checks

When JSON/request data supplies true for an integer-backed type such as db_type_range:integer, this condition treats the boolean as scalar and then casts it to the string '1', so the range check passes. That allows a boolean value through a rule whose error text and DB type both require an integer, and PostgreSQL integer columns will reject a boolean parameter instead of accepting it as 1; booleans should be excluded before casting.

Useful? React with 👍 / 👎.

refs: #252

DenTray · 2026-06-09T09:32:21Z

+        match (true) {
+            $this->resolver->isTypeCategory(DBTypeCategoryEnum::Integer, $this->type) => $this->validateInteger($attribute, $value, $min, $max, $fail),
+            $this->resolver->isTypeCategory(DBTypeCategoryEnum::Float, $this->type) => $this->validateFloat($attribute, $value, $min, $max, $fail),
+            $this->resolver->isTypeCategory(DBTypeCategoryEnum::String, $this->type) => $this->validateString($attribute, $value, $max, $fail),
+            default => null,
+        };


Suggested change

match (true) {

$this->resolver->isTypeCategory(DBTypeCategoryEnum::Integer, $this->type) => $this->validateInteger($attribute, $value, $min, $max, $fail),

$this->resolver->isTypeCategory(DBTypeCategoryEnum::Float, $this->type) => $this->validateFloat($attribute, $value, $min, $max, $fail),

$this->resolver->isTypeCategory(DBTypeCategoryEnum::String, $this->type) => $this->validateString($attribute, $value, $max, $fail),

default => null,

};

match ($this->resolver->getTypeCategory($this->type)) {

DBTypeCategoryEnum::Integer => $this->validateInteger($attribute, $value, $min, $max, $fail),

DBTypeCategoryEnum::Float => $this->validateFloat($attribute, $value, $min, $max, $fail),

DBTypeCategoryEnum::String => $this->validateString($attribute, $value, $max, $fail),

default => null,

};

DenTray · 2026-06-09T09:34:32Z

+enum DBTypeCategoryEnum: string
+{
+    case Integer = 'int';
+    case Float = 'float';
+    case String = 'string';


Suggested change

enum DBTypeCategoryEnum: string

{

case Integer = 'int';

case Float = 'float';

case String = 'string';

enum DBTypeCategoryEnum

{

case Integer;

case Float;

case String;

…ry(), removed backed enum string values; refs: #252

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 3c1b2caf25

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

chatgpt-codex-connector · 2026-06-12T06:28:31Z

+        match ($this->resolver->getTypeCategory($this->type)) {
+            DBTypeCategoryEnum::Integer => $this->validateInteger($attribute, $value, $min, $max, $fail),
+            DBTypeCategoryEnum::Float => $this->validateFloat($attribute, $value, $min, $max, $fail),
+            DBTypeCategoryEnum::String => $this->validateString($attribute, $value, $max, $fail),


Enforce lower bounds for string ranges

When a custom resolver categorizes a type as String with a non-zero lower bound, this dispatch drops $min and validateString() only checks the maximum length, so values that are shorter than the declared range pass validation. Fresh evidence in the current code is that the string branch still passes only $max, even though getRange() returns both bounds and the custom resolver extension point exposes string ranges.

Useful? React with 👍 / 👎.

For DB type validation, particularly for strings, using 0 as the lower bound makes sense. If the value is something other than zero, for example 5, that's more of a business rule than a type constraint. Laravel already provides the min validation rule for those kinds of requirements.

refs: #252

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 8d05e579d3

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

chatgpt-codex-connector · 2026-06-15T05:15:47Z

+
+    private const array RANGES = [
+        self::SMALLINT => [-32768, 32767],
+        self::INTEGER => [-2147483648, 2147483647],


Register PostgreSQL integer aliases

When callers use PostgreSQL's documented integer spellings such as int (or schema/introspection names like int2, int4, and int8), hasType() reports them as unknown because only integer, smallint, and bigint are keyed here. PostgreSQL documents these as aliases/extensions for the same integer types (https://www.postgresql.org/docs/current/datatype-numeric.html), so db_type_range:int currently throws instead of applying the existing integer range; add those aliases to the range map and category match.

Useful? React with 👍 / 👎.

vitgrams self-assigned this Mar 11, 2026

vitgrams force-pushed the 252-add-db-type-range-validation-rule branch 5 times, most recently from 9450961 to b21cb0e Compare March 11, 2026 18:38

vitgrams assigned yburlakov Mar 11, 2026

vitgrams requested a review from yburlakov March 11, 2026 18:42

vitgrams removed their assignment Mar 11, 2026

yburlakov requested changes Mar 12, 2026

View reviewed changes

Comment thread src/Rules/DbTypeRangeRule.php Outdated

yburlakov assigned vitgrams and unassigned yburlakov Mar 12, 2026

vitgrams assigned yburlakov and unassigned vitgrams Mar 12, 2026

yburlakov approved these changes Mar 12, 2026

View reviewed changes

yburlakov assigned DenTray and unassigned yburlakov Mar 12, 2026

DenTray mentioned this pull request Mar 16, 2026

Implement automatic addition of range validation rules in request classes RonasIT/laravel-entity-generator#258

Open

vitgrams mentioned this pull request Mar 19, 2026

[258]: implement automatic addition of range validation in request classes RonasIT/laravel-entity-generator#259

Open

DenTray requested a review from Copilot March 23, 2026 14:14

Copilot started reviewing on behalf of DenTray March 23, 2026 14:15 View session

Copilot AI reviewed Mar 23, 2026

View reviewed changes

yburlakov assigned vitgrams and unassigned DenTray Mar 24, 2026

vitgrams added a commit that referenced this pull request Mar 24, 2026

fix: validate numeric db type fields by value range instead of string…

1880665

… length refs: #252 Comment: #253 (comment)

vitgrams added a commit that referenced this pull request Mar 24, 2026

test: add tests to check "wrong type fails" and "uncategorized type p…

7d6a923

…asses" cases; refs: #252 Comment: #253 (comment)

vitgrams added a commit that referenced this pull request Mar 24, 2026

test: add test cases to check custom DB ranges applying

ddad7d7

refs: #252 Comment: #253 (comment)

vitgrams force-pushed the 252-add-db-type-range-validation-rule branch from 06a9d24 to 190e71e Compare March 25, 2026 07:56

vitgrams added 3 commits May 28, 2026 14:46

test: remove redundant TestDBTypeResolverWithUncategorizedTypes suppo…

2df389f

…rt resolver refs: #252

test: improve tests

713d32c

refs: #252

feat: improve Integer validation with int regex pattern

dea6e14

refs: #252

vitgrams force-pushed the 252-add-db-type-range-validation-rule branch from d1ce30a to dea6e14 Compare May 28, 2026 09:25

Merge branch 'master' into 252-add-db-type-range-validation-rule

49cab49

chatgpt-codex-connector Bot reviewed May 28, 2026

View reviewed changes

feat: guard non-scalar integer inputs before casting

da9c0e9

refs: #252

chatgpt-codex-connector Bot reviewed May 28, 2026

View reviewed changes

refactor: minor refactoring changes

8e6b579

refs: #252

vitgrams assigned DenTray and unassigned vitgrams May 29, 2026

Merge branch 'master' into 252-add-db-type-range-validation-rule

93e8a29

DenTray requested changes Jun 9, 2026

View reviewed changes

DenTray assigned vitgrams and unassigned DenTray Jun 9, 2026

refactor: replace isTypeCategory() contract method with getTypeCatego…

3c1b2ca

…ry(), removed backed enum string values; refs: #252

chatgpt-codex-connector Bot reviewed Jun 12, 2026

View reviewed changes

refactor: adjust methods order

d8f34e9

refs: #252

vitgrams assigned DenTray and unassigned vitgrams Jun 13, 2026

fix: reset DBTypeResolverContract binding after custom resolver tests

4a8f9fb

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

DenTray reviewed Jun 15, 2026

View reviewed changes

Comment thread src/Support/PostgresDBTypeResolver.php Outdated

Apply suggestion from @DenTray

28b1683

DenTray reviewed Jun 15, 2026

View reviewed changes

Comment thread src/Contracts/DBTypeResolverContract.php Outdated

Apply suggestion from @DenTray

8d05e57

chatgpt-codex-connector Bot reviewed Jun 15, 2026

View reviewed changes

DenTray approved these changes Jun 15, 2026

View reviewed changes

DenTray merged commit 1c078f5 into master Jun 15, 2026
12 checks passed

DenTray deleted the 252-add-db-type-range-validation-rule branch June 15, 2026 05:20

Uh oh!

Conversation

vitgrams commented Mar 11, 2026

Uh oh!

vitgrams commented Mar 11, 2026

Uh oh!

Uh oh!

vitgrams commented Mar 12, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

chatgpt-codex-connector Bot May 28, 2026

Choose a reason for hiding this comment

Uh oh!

vitgrams May 28, 2026

Choose a reason for hiding this comment

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

chatgpt-codex-connector Bot May 28, 2026

Choose a reason for hiding this comment

Uh oh!

vitgrams May 28, 2026

Choose a reason for hiding this comment

Uh oh!

DenTray Jun 9, 2026

Choose a reason for hiding this comment

Uh oh!

vitgrams Jun 13, 2026

Choose a reason for hiding this comment

Uh oh!

DenTray Jun 9, 2026

Choose a reason for hiding this comment

Uh oh!

vitgrams Jun 13, 2026

Choose a reason for hiding this comment

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

chatgpt-codex-connector Bot Jun 12, 2026

Choose a reason for hiding this comment

Uh oh!

vitgrams Jun 13, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

chatgpt-codex-connector Bot Jun 15, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants