-
Notifications
You must be signed in to change notification settings - Fork 14
fix: checking the state of a database with a binary field. #240
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
AZabolotnikov
wants to merge
94
commits into
master
Choose a base branch
from
azabolotnikov/fix-db-check-binary-field
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 78 commits
Commits
Show all changes
94 commits
Select commit
Hold shift + click to select a range
c95a1ab
fix: Checking the state of a database with a binary field.
AZabolotnikov 03606be
fix: Checking the state of a database with a binary field.
AZabolotnikov b68918a
fix: Checking the state of a database with a binary field.
AZabolotnikov 4b349e7
Update tests/ModelTestStateTest.php
AZabolotnikov ba961a8
fix: Checking the state of a database with a binary field.
AZabolotnikov bd8ca19
Merge remote-tracking branch 'origin/azabolotnikov/fix-db-check-binar…
AZabolotnikov 32f7886
fix: Checking the state of a database with a binary field.
AZabolotnikov f5ade29
fix: Checking the state of a database with a binary field.
AZabolotnikov 1b6250a
Update src/Testing/TableTestState.php
AZabolotnikov 9848df9
Merge branch 'master' into azabolotnikov/fix-db-check-binary-field
AZabolotnikov 4b80523
fix: Checking the state of a database with a binary field.
AZabolotnikov 8d9bcfa
Merge remote-tracking branch 'origin/azabolotnikov/fix-db-check-binar…
AZabolotnikov ff2e175
Merge branch 'master' into azabolotnikov/fix-db-check-binary-field
DenTray a0b2c76
fix: Checking the state of a database with a binary field.
AZabolotnikov f6ff34f
Merge remote-tracking branch 'origin/azabolotnikov/fix-db-check-binar…
AZabolotnikov 9484e68
fix: Checking the state of a database with a binary field.
AZabolotnikov 7473a6b
fix: Checking the state of a database with a binary field.
AZabolotnikov 4258cbc
Merge branch 'master' into azabolotnikov/fix-db-check-binary-field
DenTray c74065b
fix: Checking the state of a database with a binary field.
AZabolotnikov 8951b4b
Merge remote-tracking branch 'origin/azabolotnikov/fix-db-check-binar…
AZabolotnikov a60b08e
fix: Checking the state of a database with a binary field.
AZabolotnikov 33993e9
fix: Checking the state of a database with a binary field.
AZabolotnikov aca1a87
fix: Checking the state of a database with a binary field.
AZabolotnikov b4aeffc
Merge branch 'master' into azabolotnikov/fix-db-check-binary-field
AZabolotnikov e7fa346
fix: Checking the state of a database with a binary field.
AZabolotnikov f4a501a
Merge remote-tracking branch 'origin/azabolotnikov/fix-db-check-binar…
AZabolotnikov e72c12a
fix: Checking the state of a database with a binary field.
AZabolotnikov edad585
fix: Checking the state of a database with a binary field.
AZabolotnikov bb73fab
fix: Checking the state of a database with a binary field.
AZabolotnikov 2a976ad
fix: Checking the state of a database with a binary field.
AZabolotnikov 6fab5c9
Merge branch 'master' into azabolotnikov/fix-db-check-binary-field
AZabolotnikov c597064
fix: Checking the state of a database with a binary field.
AZabolotnikov 5e38ced
fix: Checking the state of a database with a binary field.
AZabolotnikov ab7f5d6
fix: Checking the state of a database with a binary field.
AZabolotnikov fc7f201
fix: Checking the state of a database with a binary field.
AZabolotnikov c87c21c
fix: Checking the state of a database with a binary field.
AZabolotnikov 9e161a5
fix: Checking the state of a database with a binary field.
AZabolotnikov 91ddd77
fix: Checking the state of a database with a binary field.
AZabolotnikov 348b4c7
fix: Checking the state of a database with a binary field.
AZabolotnikov f2422f4
fix: Checking the state of a database with a binary field.
AZabolotnikov 57465f5
fix: Checking the state of a database with a binary field.
AZabolotnikov a9263dc
fix: Checking the state of a database with a binary field.
AZabolotnikov cfd2a6d
fix: Checking the state of a database with a binary field.
AZabolotnikov 7aabc7f
fix: Checking the state of a database with a binary field.
AZabolotnikov b2bd039
fix: Checking the state of a database with a binary field.
AZabolotnikov a7dd48c
fix: Checking the state of a database with a binary field.
AZabolotnikov 647182d
fix: Checking the state of a database with a binary field.
AZabolotnikov 5b5297d
fix: Checking the state of a database with a binary field.
AZabolotnikov 57bcc04
fix: Checking the state of a database with a binary field.
AZabolotnikov f035b19
fix: Checking the state of a database with a binary field.
AZabolotnikov 10c4a84
fix: Checking the state of a database with a binary field.
AZabolotnikov f9a907e
fix: Checking the state of a database with a binary field.
AZabolotnikov cf3f874
fix: Checking the state of a database with a binary field.
AZabolotnikov fa5b926
fix: Checking the state of a database with a binary field.
AZabolotnikov 9652fce
fix: Checking the state of a database with a binary field.
AZabolotnikov f3ee829
fix: Checking the state of a database with a binary field.
AZabolotnikov ee3ce45
fix: Checking the state of a database with a binary field.
AZabolotnikov b3d0fba
fix: Checking the state of a database with a binary field.
AZabolotnikov d73d64d
fix: Checking the state of a database with a binary field.
AZabolotnikov 2383392
fix: Checking the state of a database with a binary field.
AZabolotnikov 6ad4db8
fix: Checking the state of a database with a binary field.
AZabolotnikov bc48582
fix: Checking the state of a database with a binary field.
AZabolotnikov f323581
fix: Checking the state of a database with a binary field.
AZabolotnikov 742b67e
Merge branch 'master' into azabolotnikov/fix-db-check-binary-field
AZabolotnikov da0e89d
fix: Checking the state of a database with a binary field.
AZabolotnikov ddc5ae8
Merge remote-tracking branch 'origin/azabolotnikov/fix-db-check-binar…
AZabolotnikov ab59651
fix: Checking the state of a database with a binary field.
AZabolotnikov 10110ef
fix: Checking the state of a database with a binary field.
AZabolotnikov 3cb3676
Merge branch 'master' into azabolotnikov/fix-db-check-binary-field
AZabolotnikov fe3863e
fix: Checking the state of a database with a binary field.
AZabolotnikov 8c3d27c
fix: Checking the state of a database with a binary field.
AZabolotnikov e59c1dd
fix: Checking the state of a database with a binary field.
AZabolotnikov 6ae0715
Merge branch 'master' into azabolotnikov/fix-db-check-binary-field
AZabolotnikov 4540130
Merge branch 'master' into azabolotnikov/fix-db-check-binary-field
AZabolotnikov 2428ea9
Merge remote-tracking branch 'origin/azabolotnikov/fix-db-check-binar…
AZabolotnikov a049bdf
fix: Checking the state of a database with a binary field.
AZabolotnikov e3171a4
fix: Checking the state of a database with a binary field.
AZabolotnikov 289f186
fix: Checking the state of a database with a binary field.
AZabolotnikov d5756ec
fix: Checking the state of a database with a binary field.
AZabolotnikov 619a525
chore: correct variables order
yburlakov fbcbd6a
chore: fix tests
9f9bb8f
chore: fix tests with aggregates wrap
43c8c71
Merge branch 'master' into azabolotnikov/fix-db-check-binary-field
yburlakov 2a757fa
Merge branch 'master' into azabolotnikov/fix-db-check-binary-field
DenTray e5da600
Update src/Testing/TableTestState.php
AZabolotnikov 854f968
Update tests/support/Mock/Casts/BinaryCast.php
AZabolotnikov 3a8b5fc
Update tests/support/Mock/Casts/BinaryCast.php
AZabolotnikov 285125d
Update src/Testing/TableTestState.php
AZabolotnikov 2216458
fix: strict change detection in TableTestState
AZabolotnikov b4c8b90
Merge remote-tracking branch 'origin/azabolotnikov/fix-db-check-binar…
AZabolotnikov 4510af2
fix: strict change detection in TableTestState
AZabolotnikov c2e40b0
fix: strict change detection in TableTestState
AZabolotnikov 505487f
Merge branch 'master' into azabolotnikov/fix-db-check-binary-field
AZabolotnikov 01fa046
Merge branch 'master' into azabolotnikov/fix-db-check-binary-field
AZabolotnikov File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 changes: 1 addition & 1 deletion
2
tests/fixtures/FixturesTraitTest/get_fixture/exists_fixture.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,3 +1,3 @@ | ||
| [ | ||
| "Test" | ||
| ] | ||
| ] |
10 changes: 10 additions & 0 deletions
10
tests/fixtures/TableTestStateTest/db_changes/test_models/binary_string_to_null_changes.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,10 @@ | ||
| { | ||
| "updated": [ | ||
| { | ||
| "id": 1, | ||
| "cast_binary_field": null | ||
| } | ||
| ], | ||
| "created": [], | ||
| "deleted": [] | ||
| } |
10 changes: 10 additions & 0 deletions
10
...s/fixtures/TableTestStateTest/db_changes/test_models/null_to_binary_resource_changes.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,10 @@ | ||
| { | ||
| "updated": [ | ||
| { | ||
| "id": 1, | ||
| "binary_field": "31ee76261d87fed8cb9d4c465c48158c" | ||
| } | ||
| ], | ||
| "created": [], | ||
| "deleted": [] | ||
| } |
10 changes: 10 additions & 0 deletions
10
tests/fixtures/TableTestStateTest/db_changes/test_models/null_to_binary_string_changes.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,10 @@ | ||
| { | ||
| "updated": [ | ||
| { | ||
| "id": 1, | ||
| "cast_binary_field": "31ee76261d87fed8cb9d4c465c48158c" | ||
| } | ||
| ], | ||
| "created": [], | ||
| "deleted": [] | ||
| } |
10 changes: 10 additions & 0 deletions
10
tests/fixtures/TableTestStateTest/db_changes/test_models/unsupported_db_driver.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,10 @@ | ||
| { | ||
| "updated": [], | ||
| "created": [], | ||
| "deleted": [ | ||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. looks strange, it should contains only updated |
||
| { | ||
| "id": 1, | ||
| "name": "name" | ||
| } | ||
| ] | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,18 @@ | ||
| <?php | ||
|
|
||
| namespace RonasIT\Support\Tests\Support\Mock\Casts; | ||
|
|
||
| use Illuminate\Contracts\Database\Eloquent\CastsAttributes; | ||
|
|
||
| class BinaryCast implements CastsAttributes | ||
| { | ||
| public function get($model, $key, $value, $attributes) | ||
| { | ||
| return is_null($value) ? $value : bin2hex($value); | ||
|
AZabolotnikov marked this conversation as resolved.
Outdated
|
||
| } | ||
|
|
||
| public function set($model, $key, $value, $attributes) | ||
| { | ||
| return is_null($value) ? $value : md5($value, true); | ||
|
AZabolotnikov marked this conversation as resolved.
Outdated
|
||
| } | ||
| } | ||
|
AZabolotnikov marked this conversation as resolved.
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.