#81: HttpRequestService ability to work with multipart #112
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adil9994
changed the title
added 2 commits
April 13, 2024 19:05
DenTray
requested changes
Apr 16, 2024
|
|
||
| protected function getMultipartOptionReplacement(array $data): array | ||
| { | ||
| Arr::forget($this->options, 'headers.content-type'); |
There was a problem hiding this comment.
please increase Laravel min version requirements up to 5.7
| @@ -127,8 +128,19 @@ public function send(string $method, string $url, array $data = [], array $heade | |||
| } | |||
| } | |||
|
|
|||
| public function parseMultipart(string $content): StreamedPart | |||
There was a problem hiding this comment.
Suggested change
| public function parseMultipart(string $content): StreamedPart | |
| public function multipart(): Generator |
There was a problem hiding this comment.
let's get content from the response instead
| fwrite($stream, $content); | ||
| rewind($stream); | ||
|
|
||
| return app()->makeWith(StreamedPart::class, ['stream' => $stream]); |
There was a problem hiding this comment.
Suggested change
| return app()->makeWith(StreamedPart::class, ['stream' => $stream]); | |
| return app() | |
| ->makeWith(StreamedPart::class, ['stream' => $stream]) | |
| ->getParts(); |
| } else { | ||
| $this->options['body'] = json_encode($data); | ||
| } | ||
| } | ||
|
|
||
| protected function getMultipartOptionReplacement(array $data): array |
There was a problem hiding this comment.
Suggested change
| protected function getMultipartOptionReplacement(array $data): array | |
| protected function convertToMultipart(array $data): array |
|
|
||
| protected function getMultipartOptionReplacement(array $data): array | ||
| { | ||
| Arr::forget($this->options, 'headers.content-type'); |
There was a problem hiding this comment.
let's move this logic out of this function
| return $options; | ||
| } | ||
|
|
||
| protected function getArrayMultipartOptionReplacement(string $parentKey, array $items): array |
There was a problem hiding this comment.
please keep only one method convertToMultipart with optional parentKey arg
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.