feat: implement addItemToReturnArray method by artengin · Pull Request #69 · RonasIT/larabuilder

artengin · 2026-05-12T09:01:30Z

refs: #71

artengin · 2026-05-12T09:02:12Z

It inherits from this commit: #64

coveralls · 2026-05-12T09:03:46Z

Coverage Report for CI Build 27781083233

Coverage increased (+0.2%) to 98.871%

Details

Coverage increased (+0.2%) from the base build.
Patch coverage: 64 of 64 lines across 8 files are fully covered (100%).
No coverage regressions found.

Uncovered Changes

No uncovered changes found.

Coverage Regressions

No coverage regressions found.

Coverage Stats


Relevant Lines:	443
Covered Lines:	438
Line Coverage:	98.87%
Coverage Strength:	10.64 hits per line

💛 - Coveralls

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: b3b724c1f4

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 2d7ffe63e6

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

artengin · 2026-06-08T06:42:00Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 3fadeec638

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

chatgpt-codex-connector · 2026-06-08T06:44:58Z

+    protected function parsePHPCode(string $code): array
+    {
+        try {
+            $stmts = new ParserFactory()->createForHostVersion()->parse("<?php\n{$code};");


Reject statements before embedding array values

When addItemToReturnArray() is called with syntactically valid PHP that is not a single expression, such as return 1 or $a = 1; $b = 2, this parser accepts it here and PreformattedExpression later prints the raw text inside an array item. That produces invalid generated PHP like return [return 1,]; instead of throwing InvalidPHPCodeException, so callers can corrupt the target file with an input that passed validation.

Useful? React with 👍 / 👎.

Validate PHP syntax only. Semantic correctness of the value is the caller's responsibility, like elsewhere in this library.

refs: #71

…return-array

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: cf924f2562

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

…le returns

…ssion

artengin · 2026-06-10T15:25:37Z

@codex review

chatgpt-codex-connector · 2026-06-10T15:28:46Z

💡 Codex Review

larabuilder/src/Visitors/MethodVisitors/AddItemToReturnArray.php

Line 47 in b3fc7be

    
           $returnNodes = new NodeFinder()->findInstanceOf($node->stmts ?? [], Return_::class);

Ignore nested returns when locating the method return

When the target method contains a closure or anonymous function before its own returned array, NodeFinder::findInstanceOf() recursively counts that nested return as part of the method, so a valid method like one building a callback and then return [...] will throw MultipleReturnStatementsException instead of updating the array. The search should skip nested function/class scopes or otherwise identify only returns that belong to the target method body.

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

…d closures

artengin · 2026-06-10T16:56:17Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: ca7af3fd92

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

chatgpt-codex-connector · 2026-06-10T16:59:39Z

+    protected function validatePHPCode(string $code): void
+    {
+        try {
+            new ParserFactory()->createForHostVersion()->parse("<?php\n{$code}?>");


Reject statements before embedding expressions

When $value or $key is a syntactically valid PHP statement but not an expression (for example return 1; or if ($x) {}), this validation succeeds because it parses the snippet as a whole PHP file. The same raw text is then printed inside an array item expression by AddItemToReturnArray, producing an invalid PHP file instead of throwing InvalidPHPCodeException; validate these snippets specifically as expressions before accepting them.

Useful? React with 👍 / 👎.

…return-array

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 58b0487bcd

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

chatgpt-codex-connector · 2026-06-18T18:39:21Z

+    case First = 'first';
+    case Second = 'second';


Declare the test enum as backed before assigning values

Because this remains enum SomeEnum rather than enum SomeEnum: string, adding scalar case values makes the file fatal when PHP loads or lints it (Case First of non-backed enum ... must not have a value). The enum-related fixtures generated from this file are now invalid PHP, so add : string or keep unit cases before relying on these tests.

Useful? React with 👍 / 👎.

chatgpt-codex-connector · 2026-06-18T18:39:21Z

+                && !empty($item->key)
+                && $printer->prettyPrintExpr($item->key) === $this->keyExpr->value
+            ) {
+                $item->value = $this->valueExpr;


Reset by-reference flags when replacing array items

If the existing return array contains a keyed by-reference item, e.g. 'role' => &$role, this replacement leaves the original ArrayItem::$byRef flag set while swapping in the new preformatted expression. The printer will then emit invalid PHP such as 'role' => &'admin', so updating a valid return array can corrupt the file; reset byRef or replace the whole ArrayItem when changing the value.

Useful? React with 👍 / 👎.

artengin self-assigned this May 12, 2026

chatgpt-codex-connector Bot reviewed May 12, 2026

View reviewed changes

Comment thread src/Visitors/MethodVisitors/AddMethod.php

artengin force-pushed the create-add-item-to-return-array branch from b3b724c to 2d7ffe6 Compare June 8, 2026 06:36

chatgpt-codex-connector Bot reviewed Jun 8, 2026

View reviewed changes

Comment thread src/Nodes/PreformattedExpression.php Outdated

Comment thread src/Visitors/MethodVisitors/AddItemToReturnArray.php

chatgpt-codex-connector Bot reviewed Jun 8, 2026

View reviewed changes

artengin added 3 commits June 10, 2026 15:27

feat: implement addItemToReturnArray method

d289350

refs: #71

Merge remote-tracking branch 'origin/master' into create-add-item-to-…

1f165a0

…return-array

fix: remarks

cf924f2

artengin force-pushed the create-add-item-to-return-array branch from 3fadeec to cf924f2 Compare June 10, 2026 12:27

chatgpt-codex-connector Bot reviewed Jun 10, 2026

View reviewed changes

Comment thread src/Nodes/PreformattedExpression.php Outdated

artengin added 2 commits June 10, 2026 17:40

feat: throw MultipleReturnStatementsException for methods with multip…

b88c431

…le returns

fix: correct PHP code parsing and value trimming in PreformattedExpre…

b3fc7be

…ssion

artengin added 2 commits June 10, 2026 18:50

fix: handle reserved words in addItemToReturnArray

aab7ff3

fix: avoid false positive MultipleReturnStatementsException for neste…

ca7af3f

…d closures

chatgpt-codex-connector Bot reviewed Jun 10, 2026

View reviewed changes

artengin assigned DenTray and unassigned artengin Jun 10, 2026

Merge remote-tracking branch 'origin/master' into create-add-item-to-…

58b0487

…return-array

chatgpt-codex-connector Bot reviewed Jun 18, 2026

View reviewed changes

Uh oh!

Conversation

artengin commented May 12, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

artengin commented May 12, 2026

Uh oh!

coveralls commented May 12, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Coverage Report for CI Build 27781083233

Coverage increased (+0.2%) to 98.871%

Details

Uncovered Changes

Coverage Regressions

Coverage Stats

💛 - Coveralls

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

artengin commented Jun 8, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

chatgpt-codex-connector Bot Jun 8, 2026

Choose a reason for hiding this comment

Uh oh!

artengin Jun 10, 2026

Choose a reason for hiding this comment

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

artengin commented Jun 10, 2026

Uh oh!

chatgpt-codex-connector Bot commented Jun 10, 2026

💡 Codex Review

Uh oh!

artengin commented Jun 10, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

chatgpt-codex-connector Bot Jun 10, 2026

Choose a reason for hiding this comment

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

chatgpt-codex-connector Bot Jun 18, 2026

Choose a reason for hiding this comment

Uh oh!

chatgpt-codex-connector Bot Jun 18, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

artengin commented May 12, 2026 •

edited

Loading

coveralls commented May 12, 2026 •

edited

Loading