Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH-498 Fabric command supports alias. Add an option to change the brigadier input inspection display. #498

Merged
merged 4 commits into from
Dec 22, 2024

Conversation

huanmeng-qwq
Copy link
Contributor

No description provided.

@huanmeng-qwq
Copy link
Contributor Author

@Rollczi

@Rollczi Rollczi changed the title fabric command supports alias GH-498 Fabric command supports alias. Add an option to change the brigadier input inspection display. Dec 22, 2024
@Rollczi
Copy link
Owner

Rollczi commented Dec 22, 2024

Thank you for the contribution @huanmeng-qwq! It turns out we no longer need to have an abstraction for the command thanks to your change related to sender factory

I added a small unrelated change (with unit tests)

@Rollczi Rollczi merged commit 47db6a8 into Rollczi:master Dec 22, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants