-
-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Sponge platform support #369
Add Sponge platform support #369
Conversation
Fixed all merge and build issues |
Hi @BlackBaroness, Thanks for your Pull Request! We can fix this, but next time you will have to:
When you are done above, you can cherry-pick the commits from old branch. In IntelliJ you can easily check the last commits (for master or other your branches) to verify them. |
@Rollczi There is no problem with it actually, you can just squash my PR and only changed files will be changed (I checked it and there are only required ones, only sponge-related). It was my mistake, I didn't reset my branch so it's based on Instant support branch, not master. But since there are no merge conflicts and I removed all wrong changes, we can just merge. Squash will remove that history anyway Just look at changed files, if you squash it, only these will be changed, nothing else, history will do nothing here |
The history of your branch is very messed up, if you want this pull request to be merged, create a new branch and do ctrl + c and ctrl + v of your changes that add sponge, your code contains code that is not even on the master. Even though "THEORETICALLY" squash solves the issue, your pull request still has a damaged history. Come when you fix it! this is an example of your damaged git history: |
Closes #230
Hi, sorry for being super late!
Here is a Sponge 8 support (it's the latest stable API, included in all modern Sponge builds).
I added a
Player
argument,Player
contextual and test/tp <player> [player]
command. You can test it yourself using./gradlew :examples:sponge:runServer
. I also wanted to add a/gm
command, but Sponge has... special... API design and I couldn't understand how to make proper suggestions (but the parsing was relatively fine). However, I believe it's enough for this platform.