Fix CompletableFuture handing in ExecuteResultHandler and 2.3.1 Release

Rollczi · Jul 5, 2022 · dc5d620 · dc5d620
1 parent 4e0e194
commit dc5d620
Show file tree

Hide file tree

Showing 8 changed files with 17 additions and 17 deletions.
diff --git a/README.md b/README.md
@@ -4,7 +4,7 @@
 Helpful links:
 - [Support Discord](https://discord.gg/6cUhkj6uZJ)
 - [GitHub issues](https://github.com/Rollczi/LiteCommands/issues)
-- [Example (Modern 2.3.0)](https://github.com/Rollczi/LiteCommands/tree/master/examples/bukkit)
+- [Example (Modern 2.3.1)](https://github.com/Rollczi/LiteCommands/tree/master/examples/bukkit)
 - [Docs (Legacy 1.7.2)](https://docs.rollczi.dev/)
 
 ### Panda Repository (Maven or Gradle)  ❤️
@@ -23,11 +23,11 @@ Framework Core
 <dependency>
     <groupId>dev.rollczi.litecommands</groupId>
     <artifactId>core</artifactId>
-    <version>2.3.0</version>
+    <version>2.3.1</version>
 </dependency>
 ```
 ```groovy
-implementation 'dev.rollczi.litecommands:core:2.3.0'
+implementation 'dev.rollczi.litecommands:core:2.3.1'
 ```
 
 ### First Simple Command
@@ -57,11 +57,11 @@ Add this to your dependencies if you want use ready-made implementation for velo
 <dependency>
     <groupId>dev.rollczi.litecommands</groupId>
     <artifactId>velocity</artifactId>
-    <version>2.3.0</version>
+    <version>2.3.1</version>
 </dependency>
 ```
 ```groovy
-implementation 'dev.rollczi.litecommands:velocity:2.3.0'
+implementation 'dev.rollczi.litecommands:velocity:2.3.1'
 ```
 
 #### All extensions: 

diff --git a/build.gradle.kts b/build.gradle.kts
@@ -14,7 +14,7 @@ plugins {
 
 allprojects {
     group = "dev.rollczi.litecommands"
-    version = "2.3.0"
+    version = "2.3.1"
 
     apply(plugin = "java-library")
     apply(plugin = "maven-publish")

diff --git a/examples/bukkit/build.gradle.kts b/examples/bukkit/build.gradle.kts
@@ -10,7 +10,7 @@ repositories {
 
 dependencies {
     compileOnly("org.spigotmc:spigot-api:1.19-R0.1-SNAPSHOT")
-    // implementation("dev.rollczi.litecommands:bukkit:2.3.0") // <-- uncomment in your project
+    // implementation("dev.rollczi.litecommands:bukkit:2.3.1") // <-- uncomment in your project
     implementation(project(":litecommands-bukkit")) // don't use this line in your build.gradle
 
     testImplementation("org.junit.jupiter:junit-jupiter-api:5.8.1")

diff --git a/litecommands-bukkit-adventure/README.md b/litecommands-bukkit-adventure/README.md
@@ -4,10 +4,10 @@ Maven
 <dependency>
     <groupId>dev.rollczi.litecommands</groupId>
     <artifactId>bukkit-adventure</artifactId>
-    <version>2.3.0</version>
+    <version>2.3.1</version>
 </dependency>
 ```
 Gradle
 ```groovy
-implementation 'dev.rollczi.litecommands:bukkit-adventure:2.3.0'
+implementation 'dev.rollczi.litecommands:bukkit-adventure:2.3.1'
 ```
diff --git a/litecommands-bukkit/README.md b/litecommands-bukkit/README.md
@@ -4,12 +4,12 @@ Maven
 <dependency>
     <groupId>dev.rollczi.litecommands</groupId>
     <artifactId>bukkit</artifactId>
-    <version>2.3.0</version>
+    <version>2.3.1</version>
 </dependency>
 ```
 Gradle
 ```groovy
-implementation 'dev.rollczi.litecommands:bukkit:2.3.0'
+implementation 'dev.rollczi.litecommands:bukkit:2.3.1'
 ```
 
 #### Examples:

diff --git a/litecommands-bungee/README.md b/litecommands-bungee/README.md
@@ -4,12 +4,12 @@ Maven
 <dependency>
     <groupId>dev.rollczi.litecommands</groupId>
     <artifactId>bungee</artifactId>
-    <version>2.3.0</version>
+    <version>2.3.1</version>
 </dependency>
 ```
 Gradle
 ```groovy
-implementation 'dev.rollczi.litecommands:bungee:2.3.0'
+implementation 'dev.rollczi.litecommands:bungee:2.3.1'
 ```
 
 #### Examples:

diff --git a/litecommands-core/src/main/java/dev/rollczi/litecommands/handle/ExecuteResultHandler.java b/litecommands-core/src/main/java/dev/rollczi/litecommands/handle/ExecuteResultHandler.java
@@ -41,13 +41,13 @@ public void handle(SENDER sender, LiteInvocation invocation, ExecuteResult resul
         if (object instanceof CompletableFuture<?>) {
             CompletableFuture<?> future = ((CompletableFuture<?>) object);
 
-            future.whenComplete((o, ex) -> {
+            future.whenComplete((obj, ex) -> {
                 if (ex != null) {
                     ex.printStackTrace();
                     return;
                 }
 
-                this.handleResult(sender, invocation, result);
+                this.handleResult(sender, invocation, obj);
             });
 
             return;

diff --git a/litecommands-velocity/README.md b/litecommands-velocity/README.md
@@ -4,12 +4,12 @@ Maven
 <dependency>
     <groupId>dev.rollczi.litecommands</groupId>
     <artifactId>velocity</artifactId>
-    <version>2.3.0</version>
+    <version>2.3.1</version>
 </dependency>
 ```
 Gradle
 ```groovy
-implementation 'dev.rollczi.litecommands:velocity:2.3.0'
+implementation 'dev.rollczi.litecommands:velocity:2.3.1'
 ```
 
 #### Examples: